-
-
Notifications
You must be signed in to change notification settings - Fork 2
Description
Traefik configs are working fine, but it appears as if a few lines of code could be cleaned up.
This is an unused middleware as Auth is not needed on public site 2023.ploneconf.org. Label could be removed.
2023.ploneconf.org/devops/stacks/2023.ploneconf.org.yml
Lines 25 to 26 in 5fb7d21
| ### ClassicUI Access Authentication | |
| - traefik.http.middlewares.2023_ploneconf-frontend-auth.basicauth.users=ploneconf:$$2y$$05$$SLsKIKgK.NlD.64HMV42hOUNi3pQM/T.iW4qziWs0xcKHzkaa8T8C |
As you can see, the 2023_ploneconf-frontend-auth middleware is not referenced here anyway.
| - traefik.http.routers.2023_ploneconf-frontend.middlewares=gzip |
This is the correct use of middleware as Auth is needed on private site testing.ploneconf.org
2023.ploneconf.org/devops/stacks/testing.ploneconf.org.yml
Lines 25 to 26 in 5fb7d21
| ### ClassicUI Access Authentication | |
| - traefik.http.middlewares.testing_ploneconf-frontend-auth.basicauth.users=ploneconf:$$2y$$05$$SLsKIKgK.NlD.64HMV42hOUNi3pQM/T.iW4qziWs0xcKHzkaa8T8C |
As you can see, the testing_ploneconf-frontend-auth middleware is actually referenced here.
| - traefik.http.routers.testing_ploneconf-frontend.middlewares=gzip,testing_ploneconf-frontend-auth |
Change comment here to ### testing.ploneconf.org Access Authentication
| ### ClassicUI Access Authentication |