Javascript package problem on Jenkins 5.1 due to grunt version

[mauritsvanrees]

The Plone 5.1 JavaScript Jenkins job is broken since this weekend. See http://jenkins.plone.org/job/plone-5.1-js/4/
The previous job run was on 28 April, so this is not regularly run. Jenkins says it was started by this push to mockup, but that seems totally innocent: plone/mockup@cbfd3fd
I tried a manual rebuild, but it gives the same error:

npm ERR! peerinvalid The package grunt does not satisfy its siblings'
  peerDependencies requirements!
npm ERR! peerinvalid Peer grunt-karma@1.0.0 wants grunt@>=0.4.x
npm ERR! peerinvalid Peer grunt-sed@0.1.1 wants grunt@~0.4
npm ERR! peerinvalid Peer grunt-contrib-jshint@1.0.0 wants grunt@>=0.4.0

[l34marr]

I run into the same error message when following the instruction at http://mockup-training.readthedocs.io/ Somehow it seems to be fixed by the hint at http://github.com/gruntjs/grunt/issues/1488 Specifically I change the mockup/package.json file with this: "grunt": ">=0.4.5 <1.0.0"

HTH

[gforcada]

@l34marr would you mind providing a pull request to mockup with this fix?

[l34marr]

@gforcada Based on http://gruntjs.com/blog/2016-04-04-grunt-1.0.0-released#peer-dependencies I guess the right way is to fix the Grunt plugin, which in our case is grunt-sed. The update is at jharding/grunt-sed#16 but not yet be merged and released. My JavaScript knowledge is limited, but I don't think it's a good idea to fix mockup/package.json file this way. Hints are appreciated.

[gforcada]

@l34marr no problem at all! as I saw you providing some hints on the root cause I thought that it could be solved on our side, but if there is a PR already fixing it upstream, then let's push for that PR and update to the version that contains it once is released.

Thanks for finding the issue and pull request!

[gforcada]

I have a solution at plone/mockup#702 as npm allows to use github URLs as versions, we can fork a fix for it and use that 👍

[gforcada]

That was merged long ago.