Skip to content

https://dev.plone.org/ticket/12433 reopened: BrowserView method name can cause error in portal_view_customizations #9

Description

@d-maurer

The current "plone.app.customerize.register" contains the following code

def templateViewRegistrations():
    regs = []
    for reg in getViews(IBrowserRequest):
        factory = reg.factory
        while hasattr(factory, 'factory'):
            factory = factory.factory
        ....

The while hasattr(factory, 'factory'): factory = factory.factory loop is causing the problem described in "https://dev.plone.org/ticket/12433" - which therefore is still there in the current Plone versions.

I have eliminated this loop and still all tests pass. Apparently, it is not relevant for the proper functioning of "plone.app.customerize". Does anyone still knows for what purpose the loop has been introduced?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions