Skip to content

Commit cb5c382

Browse files
Remove unneeded backwards compatibility code for old Zope and Plone versions.
1 parent 30524a9 commit cb5c382

4 files changed

Lines changed: 6 additions & 31 deletions

File tree

news/+d90ae288.bugfix.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove unneeded backwards compatibility code for old Zope and Plone versions. [maurits]

src/plone/app/drafts/browser/view.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
from datetime import datetime
22
from plone.app.uuid.utils import uuidToObject
3-
4-
5-
try:
6-
from urllib import quote
7-
except ImportError:
8-
from urllib.parse import quote
3+
from urllib.parse import quote
94

105

116
class View:

src/plone/app/drafts/dexterity.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
from plone.dexterity.interfaces import IDexterityContent
1414
from plone.dexterity.interfaces import IDexterityFTI
1515
from plone.dexterity.utils import createContent
16+
from plone.protect.interfaces import IDisableCSRFProtection
1617
from plone.uuid.interfaces import IMutableUUID
1718
from plone.uuid.interfaces import IUUID
1819
from z3c.form.field import FieldWidgets as FieldWidgetsBase
@@ -33,14 +34,6 @@
3334
import transaction
3435

3536

36-
try:
37-
from plone.protect.interfaces import IDisableCSRFProtection
38-
39-
HAS_PLONE_PROTECT = True
40-
except ImportError:
41-
HAS_PLONE_PROTECT = False
42-
43-
4437
AUTOSAVE_BLACKLIST = [
4538
"IShortName.id",
4639
]
@@ -233,9 +226,8 @@ def autosave(event): # noqa
233226
for key, value in values.items():
234227
setattr(draft, key, value)
235228

236-
# Disable Plone 5 implicit CSRF to update draft
237-
if HAS_PLONE_PROTECT:
238-
alsoProvides(request, IDisableCSRFProtection)
229+
# Disable implicit CSRF to update draft
230+
alsoProvides(request, IDisableCSRFProtection)
239231

240232

241233
@adapter(IDexterityContent, IObjectAddedEvent)

src/plone/app/drafts/tests.py

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from pkg_resources import parse_version
21
from plone.app.drafts.draft import Draft
32
from plone.app.drafts.interfaces import DRAFT_NAME_KEY
43
from plone.app.drafts.interfaces import ICurrentDraftManagement
@@ -30,7 +29,6 @@
3029
from zope.component import queryUtility
3130
from zope.interface import implementer
3231

33-
import pkg_resources
3432
import transaction
3533
import unittest
3634

@@ -553,19 +551,8 @@ def test_discard(self):
553551
current = ICurrentDraftManagement(request)
554552
current.discard()
555553

556-
expires = "Wed, 31-Dec-97 23:59:59 GMT"
557-
558-
try:
559-
# expires date changed in ZPublisher.HTTPResponse
560-
# see https://github.com/zopefoundation/Zope/commit/77f483a22d6b0cb00883006cf38928cda77b75f9
561-
zope_version = pkg_resources.get_distribution("Zope").version
562-
if parse_version(zope_version) >= parse_version("4.0b8"):
563-
expires = "Wed, 31 Dec 1997 23:59:59 GMT"
564-
except Exception:
565-
pass
566-
567554
deletedToken = {
568-
"Expires": expires,
555+
"Expires": "Wed, 31 Dec 1997 23:59:59 GMT",
569556
"Max-Age": "0",
570557
"Path": "/",
571558
"value": "deleted",

0 commit comments

Comments
 (0)