-
-
Notifications
You must be signed in to change notification settings - Fork 899
Open
Description
But the tests aren't only failing because of that. When you change a dependency, you need to run
make installand commit the resultingpnpm-lock.yamlfile.
Do we have this step documented? I did a quick scan in the Volto Contributing folder, and it's not there. I found only two mentions of make install.
- https://6.docs.plone.org/volto/contributing/developing-core.html
- https://6.docs.plone.org/volto/contributing/linting.html
New-to-Volto contributors would never know this without experienced developers telling them.
@Kathrina-dev can you help us improve the documentation by giving us your perspective of where you would look for such information? Since this is part of testing, perhaps one or both of these files?
- https://6.docs.plone.org/volto/contributing/testing.html
- https://6.docs.plone.org/volto/contributing/acceptance-tests.html
@wesleybl what do you think?
Thank you, both of you!
Originally posted by @stevepiercy in #7868 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Type
Projects
Status
New