Skip to content

Document to run make install when changing a dependency #7922

@stevepiercy

Description

@stevepiercy

But the tests aren't only failing because of that. When you change a dependency, you need to run make install and commit the resulting pnpm-lock.yaml file.

Do we have this step documented? I did a quick scan in the Volto Contributing folder, and it's not there. I found only two mentions of make install.

New-to-Volto contributors would never know this without experienced developers telling them.

@Kathrina-dev can you help us improve the documentation by giving us your perspective of where you would look for such information? Since this is part of testing, perhaps one or both of these files?

@wesleybl what do you think?

Thank you, both of you!

Originally posted by @stevepiercy in #7868 (comment)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    New

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions