Skip to content

Commit 508f8f5

Browse files
authored
Dash for R v0.7.1 (#221)
2 parents cfa29d6 + 3ca561b commit 508f8f5

8 files changed

+15
-40165
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
All notable changes to `dash` will be documented in this file.
33
This project adheres to [Semantic Versioning](http://semver.org/).
44

5+
## [0.7.1] - 2020-07-30
6+
### Fixed
7+
- Fixes a minor bug in debug mode that prevented display of user-defined error messages when induced by invoking the `stop` function. [#220](https://github.com/plotly/dashR/pull/220).
8+
- URLs for unpkg.com for dash-renderer were outdated, and now fetch v1.6.0 also; `dash-renderer` v1.5.1 has been removed from `inst/lib`.
9+
510
## [0.7.0] - 2020-07-28
611
### Added
712
- Dash for R now supports an `update_title` parameter, as in Dash for Python. [#218](https://github.com/plotly/dashR/pull/218)

DESCRIPTION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: dash
22
Title: An Interface to the Dash Ecosystem for Authoring Reactive Web Applications
3-
Version: 0.7.0
3+
Version: 0.7.1
44
Authors@R: c(person("Chris", "Parmer", role = c("aut"), email = "[email protected]"), person("Ryan Patrick", "Kyle", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-5829-9867"), email = "[email protected]"), person("Carson", "Sievert", role = c("aut"), comment = c(ORCID = "0000-0002-4958-2844")), person("Hammad", "Khan", role = c("aut"), email = "[email protected]"), person(family = "Plotly Technologies", role = "cph"))
55
Description: A framework for building analytical web applications, Dash offers a pleasant and productive development experience. No JavaScript required.
66
Depends:

R/internal.R

+4-4
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
class = "html_dependency"),
3838
`dash-renderer-dev` = structure(list(name = "dash-renderer",
3939
version = "1.6.0",
40-
src = list(href = "https://unpkg.com/dash-renderer@1.5.1",
40+
src = list(href = "https://unpkg.com/dash-renderer@1.6.0",
4141
file = "lib/[email protected]"),
4242
meta = NULL,
4343
script = "dash-renderer/dash_renderer.dev.js",
@@ -49,7 +49,7 @@
4949
class = "html_dependency"),
5050
`dash-renderer-map-dev` = structure(list(name = "dash-renderer",
5151
version = "1.6.0",
52-
src = list(href = "https://unpkg.com/dash-renderer@1.5.1",
52+
src = list(href = "https://unpkg.com/dash-renderer@1.6.0",
5353
file = "lib/[email protected]"),
5454
meta = NULL,
5555
script = "dash-renderer/dash_renderer.dev.js.map",
@@ -61,7 +61,7 @@
6161
class = "html_dependency"),
6262
`dash-renderer-prod` = structure(list(name = "dash-renderer",
6363
version = "1.6.0",
64-
src = list(href = "https://unpkg.com/dash-renderer@1.5.1",
64+
src = list(href = "https://unpkg.com/dash-renderer@1.6.0",
6565
file = "lib/[email protected]"),
6666
meta = NULL,
6767
script = "dash-renderer/dash_renderer.min.js",
@@ -73,7 +73,7 @@
7373
class = "html_dependency"),
7474
`dash-renderer-map-prod` = structure(list(name = "dash-renderer",
7575
version = "1.6.0",
76-
src = list(href = "https://unpkg.com/dash-renderer@1.5.1",
76+
src = list(href = "https://unpkg.com/dash-renderer@1.6.0",
7777
file = "lib/[email protected]"),
7878
meta = NULL,
7979
script = "dash-renderer/dash_renderer.min.js.map",

R/utils.R

+5-9
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,7 @@ stackTraceToHTML <- function(call_stack,
747747
# stack will be "pruned" of error handling functions
748748
# for greater readability.
749749
getStackTrace <- function(expr, debug = FALSE, prune_errors = TRUE) {
750-
if(debug) {
750+
if (debug) {
751751
tryCatch(withCallingHandlers(
752752
expr,
753753
error = function(e) {
@@ -813,22 +813,18 @@ getStackTrace <- function(expr, debug = FALSE, prune_errors = TRUE) {
813813
} else if (currentCall[[1]] == "stop") {
814814
# handle case where function developer deliberately invokes a stop
815815
# condition and halts function execution
816-
identical(deparse(errorCall), deparse(currentCall))
817-
}
818-
else {
816+
TRUE
817+
} else {
819818
FALSE
820819
}
821-
822-
}
823-
)
824-
)
820+
}))
825821
# the position to stop at is one less than the difference
826822
# between the total number of calls and the index of the
827823
# call throwing the error
828824
stopIndex <- length(calls) - indexFromLast + 1
829825

830826
startIndex <- match(TRUE, lapply(functionsAsList, function(fn) fn == "getStackTrace"))
831-
functionsAsList <- functionsAsList[startIndex:stopIndex]
827+
functionsAsList <- functionsAsList[seq(startIndex, stopIndex)]
832828
functionsAsList <- removeHandlers(functionsAsList)
833829
}
834830

0 commit comments

Comments
 (0)