Skip to content

Commit c1c51f3

Browse files
authored
Merge pull request #216 from plotly/457-remove-warning
Remove no IDs warning
2 parents eb44067 + d874e85 commit c1c51f3

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
All notable changes to `dash` will be documented in this file.
33
This project adheres to [Semantic Versioning](http://semver.org/).
44

5+
## [0.6.4] - 2020-07-14
6+
**Changed**
7+
- Removes warning message when an app is launched without any component ID's present in the layout. When writing callbacks it iss natural to assume that an ID is necessary, and this warning may be misleading for apps without callbacks (for more details, see [#216](https://github.com/plotly/dashR/pull/216).
8+
9+
510
## [0.6.3] - 2020-06-25
611
**Changed**
712
- `dash-renderer` updated to v1.5.1

DESCRIPTION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: dash
22
Title: An Interface to the Dash Ecosystem for Authoring Reactive Web Applications
3-
Version: 0.6.3
3+
Version: 0.6.4
44
Authors@R: c(person("Chris", "Parmer", role = c("aut"), email = "[email protected]"), person("Ryan Patrick", "Kyle", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-5829-9867"), email = "[email protected]"), person("Carson", "Sievert", role = c("aut"), comment = c(ORCID = "0000-0002-4958-2844")), person("Hammad", "Khan", role = c("aut"), email = "[email protected]"), person(family = "Plotly Technologies", role = "cph"))
55
Description: A framework for building analytical web applications, Dash offers a pleasant and productive development experience. No JavaScript required.
66
Depends:

R/dash.R

+1-7
Original file line numberDiff line numberDiff line change
@@ -1226,13 +1226,7 @@ Dash <- R6::R6Class(
12261226

12271227
# verify that layout ids are unique
12281228
idx <- grep("props\\.id$", layout_nms)
1229-
if (!length(idx)) {
1230-
warning(
1231-
"No ids were found in the layout. ",
1232-
"Component ids are critical for targeting callbacks in your application",
1233-
call. = FALSE
1234-
)
1235-
}
1229+
12361230
layout_ids <- as.character(layout_flat[idx])
12371231
duped <- anyDuplicated(layout_ids) > 0
12381232

0 commit comments

Comments
 (0)