Skip to content

Remove dashR dependency on htmltools #54

Open
@rpkyle

Description

@rpkyle

Given that we are aiming for parity with Dash for Python, and that "rolling our own" dependency handling/resolution logic is a minor hurdle, it seems prudent to eliminate references to code from htmltools in dashR.

Most of the references to functions in htmltools have been excised, with the exception of

dashR/R/dash.R

Line 554 in 7fa2581

depsAll <- htmltools::resolveDependencies(depsAll, FALSE)

#' @importFrom htmltools htmlDependency htmlDependencies attachDependencies renderDependencies

dashR/R/css.R

Line 33 in 7fa2581

htmltools::htmlDependency(

dashR/R/dash.R

Line 71 in 7fa2581

#' The `dependencies` argument accepts [htmltools::htmlDependency] or

dashR/R/dash.R

Line 361 in 7fa2581

stop("`dependencies` must be a *list* of htmltools::htmlDependency objects", call. = FALSE)

Aside from removing references to this package, I'll need to write a function which has the same effect as htmltools::resolveDependencies.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions