Setup prettier #482
Setup prettier #482
Conversation
|
I would be more in favour of running it over a larger/complete set of files early on, otherwise it will make PR reviews in the future more challenging as we will have "ran prettier" interspersed with other commits... |
|
💯 It's about time 🎆 Suggestion: Consider adding Will turn To |
|
@kndungu I can't believe I've missed that option! Of course, I'll add it. |
|
@nicolaskruchten @kndungu @tarzzz Let's be pragmatic about the temporary use of pragmas. I'm not going to run The benefit of having DawnLabs' contributions formatted right away outweighs the nuisance of adding a pragma. |
|
Since you asked for my feedback, I gave it: I favour the all or nothing
approach, whether your consider that pragmatic or not. That said, my
opinion doesn’t count any more than anyone else’s here: if others feel it’s
an improvement then let’s do it.
…On Thu, Jul 5, 2018 at 16:31 Nicolas Riesco ***@***.***> wrote:
@nicolaskruchten <https://github.com/nicolaskruchten> @kndungu
<https://github.com/kndungu> @tarzzz <https://github.com/tarzzz> Let's be
pragmatic about the *temporary* use of pragmas. I'm not going to run
prettier on the whole code base just before an on-prem release.
The benefit of having DawnLabs' contributions formatted right away
outweighs the nuisance of adding a pragma.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#482 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMbA5q5gLGvjYkZZ6BPhvoXCBCHLGKGks5uDneKgaJpZM4VEOHS>
.
|
|
@mfix22 You see, most people but me want to run |
n-riesco
force-pushed
the
prettier/initial-setup
branch
from
fa88c50 to
4e90d4a
Compare
|
I'm closing since there is no interest in merging before the onprem release. |
@mfix22 @nicolaskruchten
@tarzzz @shannonlal @kndungu
I've noticed that
prettierhas an option to ignore files without apragma(see this commit for an example of how it works).I've also added
huskyto setup a git hook, so thatprettierruns automatically before agit commit.If you all are happy with this incremental approach, let's merge this PR.
Closes #475