-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
bugsomething brokensomething broken
Description
Running npm start on master produces an error: "module is not defined".
Steps to Reproduce
- Run
npm start
Expected Behavior
I started writing up this ticket because I thought this broke the test dashboard. However, it appears this console error is simply erroneous.
Actual Behavior
The test dashboard actually does not appear to break, despite the console error.
Additional Details
The CommonJS export syntax in //devtools/test_dashboard/devtools.js is at fault. It appears that ESBuild does not strip this out on build. To fix this, we could:
- Remove the
module.exports = Tabsline if this export is not needed elsewhere. - Create another file (e.g.
index.js), import the devtools from thereconst Tabs = require('./tabs');, and point ESBuild at that.

Metadata
Metadata
Assignees
Labels
bugsomething brokensomething broken