Fix correctness of patch compare function (fixes potential crash when closing nested abstractions)

timothyschoen · timothyschoen · commit a4bf08e89225 · 2026-06-10T23:20:42.000+02:00
diff --git a/Source/Pd/Patch.h b/Source/Pd/Patch.h
@@ -29,7 +29,7 @@ class Patch final : public ReferenceCountedObject {
     // The compare equal operator.
     bool operator==(Patch const& other) const
     {
-        return getRawPointer() == other.getRawPointer();
+        return getUncheckedPointer() == other.getUncheckedPointer() && ptr.isDeleted() == other.ptr.isDeleted();
     }
 
     // Gets the bounds of the patch.

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class Patch final : public ReferenceCountedObject {`
`29`	`29`	`// The compare equal operator.`
`30`	`30`	`bool operator==(Patch const& other) const`
`31`	`31`	`{`
`32`		`- return getRawPointer() == other.getRawPointer();`
	`32`	`+ return getUncheckedPointer() == other.getUncheckedPointer() && ptr.isDeleted() == other.ptr.isDeleted();`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`// Gets the bounds of the patch.`