also crystdistrib and EDS

Author: carlocamilloni

src/crystdistrib/Quaternion.cpp

@@ -149,7 +149,6 @@ Quaternion::Quaternion(const ActionOptions&ao):
   parseFlag("NOPBC",nopbc);
   pbc=!nopbc;
 
-  unsigned mode = getModeAndSetupValues( this );
   requestAtoms(atoms);
 }
 
@@ -267,7 +266,7 @@ void Quaternion::calculateCV( const colvar::ColvarInput<double>& cvin, ColvarOut
   dy[2](2,2) = 1 - fac_derivs[2][2]*vec1_comp[2];
   //now normalize, and we have our y vector
   double magy = yt.modulo();
-  double imagy = 1/magy, magy3 = magy*magy*magy;
+  double magy3 = magy*magy*magy;
   Tensor abc;
   for(unsigned i=0; i<3; ++i) {
     abc.setRow(i, yt);

src/crystdistrib/QuaternionBondProductMatrix.cpp

@@ -84,7 +84,7 @@ class QuaternionBondProductMatrix : public ActionWithVector {
 public:
   static void registerKeywords( Keywords& keys );
   explicit QuaternionBondProductMatrix(const ActionOptions&);
-  unsigned getNumberOfDerivatives();
+  unsigned getNumberOfDerivatives() override ;
   void prepare() override ;
   void calculate() override ;
   void applyNonZeroRankForces( std::vector<double>& outforces ) override ;
@@ -318,12 +318,11 @@ void QuaternionBondProductMatrix::performTask( std::size_t task_index,
 //I hold off on normalizing because this can be done at the very end, and it
 // makes the derivatives with respect to 'bond' more simple
 
-  double wf=0,xf=0,yf=0,zf=0;
+  double xf=0,yf=0,zf=0;
 
   for(unsigned i=0; i<4; ++i) {
     //real part of q1*q2
     output.values[0] += normFac*conj[i]*quatTemp[i]*quat[i];
-    wf+=normFac*conj[i]*quatTemp[i]*quat[i];
     //i component
     output.values[1] += normFac*pref_i[i]*quatTemp[i]*quat[(5-i)%4];
     xf+=normFac*pref_i[i]*quatTemp[i]*quat[(5-i)%4];

src/eds/EDS.cpp

@@ -220,7 +220,6 @@ class EDS : public Bias {
   bool b_write_restart_;
   bool b_lm_;
   bool b_virial_;
-  bool b_update_virial_;
   bool b_weights_;
   int seed_;
   int update_period_;
@@ -346,7 +345,6 @@ EDS::EDS(const ActionOptions &ao) : PLUMED_BIAS_INIT(ao),
   max_logweight_(0.0),
   wsum_(0.0),
   value_force2_(NULL) {
-  double temp = -1.0;
   bool b_mean = false;
   std::vector<Value *> wvalues;