Skip to content

Commit b2834c6

Browse files
fix ordering goofiness on cert manager/externaldns
1 parent da18c72 commit b2834c6

2 files changed

Lines changed: 2 additions & 22 deletions

File tree

helm/certmanager.yaml.liquid

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,10 @@ global:
55
installCRDs: true
66
serviceAccount:
77
name: cert-manager
8-
{% if cluster.distro == 'EKS' %}
98
annotations:
109
eks.amazonaws.com/role-arn: {{ cluster.metadata.iam.cert_manager }}
11-
{% endif %}
12-
13-
{% if cluster.distro == 'AKS' %}
14-
annotations:
1510
azure.workload.identity/client-id: {{ cluster.metadata.iam.cert_manager }}
16-
{% endif %}
17-
18-
{% if cluster.distro == 'GKE' %}
19-
annotations:
2011
iam.gke.io/gcp-service-account: {{ cluster.metadata.iam.cert_manager }}
21-
{% endif %}
2212

2313
securityContext:
2414
fsGroup: 1000

helm/external-dns.yaml.liquid

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,29 +20,19 @@ aws:
2020
domainFilters:
2121
- {{ cluster.metadata.dns_zone }} # check terraform/modules/clusters/aws/plural.tf for where this is set
2222

23-
{% if cluster.distro == "EKS" %}
24-
serviceAccount:
25-
annotations:
26-
eks.amazonaws.com/role-arn: {{ cluster.metadata.iam.external_dns }}
27-
{% endif %}
28-
2923
{% if cluster.distro == "AKS" %}
3024
azure:
3125
useWorkloadIdentityExtension: true
3226
resourceGroup: {{ cluster.metadata.resource_group_name }}
3327
tenantId: {{ cluster.metadata.tenant_id }}
3428
subscriptionId: {{ cluster.metadata.subscription_id }}
3529

36-
serviceAccount:
37-
annotations:
38-
azure.workload.identity/client-id: {{ cluster.metadata.iam.external_dns }}
39-
4030
podLabels:
4131
azure.workload.identity/use: "true"
4232
{% endif %}
4333

44-
{% if cluster.distro == "GKE" %}
4534
serviceAccount:
4635
annotations:
36+
eks.amazonaws.com/role-arn: {{ cluster.metadata.iam.external_dns }}
4737
iam.gke.io/gcp-service-account: {{ cluster.metadata.iam.external_dns }}
48-
{% endif %}
38+
azure.workload.identity/client-id: {{ cluster.metadata.iam.external_dns }}

0 commit comments

Comments
 (0)