refactor(tests): remove MemoryEngineTest and streamline Python test outputs

- Deleted `MemoryEngineTest` module for test suite simplification
- Removed unused function `tool_result_content` in `memory_engine.ex` for cleaner code
- Updated Python test cases to handle serialized outputs using `Output.json`
- Added test for bounding oversized Python output in `python_test.exs` to ensure result size compliance

Author: floreks

lib/console/ai/chat/memory_engine.ex

@@ -7,7 +7,6 @@ defmodule Console.AI.Chat.MemoryEngine do
   alias Console.AI.{Provider, Tool}
   alias Console.AI.Chat.EnabledTools
   alias Console.AI.Tools.{EnableTools, ToolSearch}
-  alias Console.AI.Tools.Workbench.Output
   require Logger
 
   @type t :: %__MODULE__{}
@@ -181,19 +180,15 @@ defmodule Console.AI.Chat.MemoryEngine do
   defp tool_msg(content, id, name, args, fun, attrs \\ %{})
   defp tool_msg(content, id, name, args, _, attrs) when is_binary(content),
     do: {:tool, content, %{call_id: id, name: name, arguments: args, attributes: attrs}}
-  defp tool_msg(%{content: content} = msg, id, name, args, _, _) when is_binary(content),
+  defp tool_msg(%{content: content} = msg, id, name, args, _, _),
     do: {:tool, content, %{call_id: id, name: name, arguments: args, attributes: Map.delete(msg, :content)}}
   defp tool_msg(result, id, name, args, fmt, attrs) when is_function(fmt, 1) do
     case fmt.(result) do
       content when is_binary(content) -> {result, {:tool, content, %{call_id: id, name: name, arguments: args, attributes: attrs}}}
-      _ -> tool_msg(tool_result_content(result), id, name, args, fmt, attrs)
+      _ -> result
     end
   end
 
-  defp tool_result_content(result), do: tool_result_content(result, Output.json(result))
-  defp tool_result_content(_, {:ok, content}), do: content
-  defp tool_result_content(result, {:error, _}), do: inspect(result)
-
   defp msg({res, {:tool, _, _}}, :result), do: res
   defp msg({_, {:tool, _, _} = tool}, :tool), do: tool
   defp msg(pass, _), do: pass

lib/console/ai/tools/workbench/python.ex

@@ -1,6 +1,7 @@
 defmodule Console.AI.Tools.Workbench.Python do
   use Console.AI.Tools.Workbench.Base
   alias CloudQuery.Client
+  alias Console.AI.Tools.Workbench.Output
   alias Toolquery.ToolQuery.Stub
   alias Toolquery.{RunPythonInput, RunPythonOutput}
 
@@ -32,7 +33,7 @@ defmodule Console.AI.Tools.Workbench.Python do
          request = %RunPythonInput{script: code, input_json: input_json},
          {:ok, %RunPythonOutput{result_json: result_json, stdout: stdout}} <- Stub.run_python(client, request, Client.cloud_query_rpc_opts()),
          {:ok, result} <- Jason.decode(result_json) do
-      {:ok, %{result: result, stdout: stdout}}
+      Output.json(%{result: result, stdout: stdout})
     end
   end
 end

test/console/ai/chat/memory_engine_test.exs

@@ -3,7 +3,7 @@ defmodule Console.AI.Tools.Workbench.PythonTest do
   use Mimic
 
   alias CloudQuery.Client
-  alias Console.AI.Tools.Workbench.Python
+  alias Console.AI.Tools.Workbench.{Output, Python}
   alias Toolquery.{RunPythonOutput}
   alias Toolquery.ToolQuery.Stub
 
@@ -22,7 +22,7 @@ defmodule Console.AI.Tools.Workbench.PythonTest do
     assert %{code: ["can't be blank"], explanation: ["can't be blank"]} = errors_on(changeset)
   end
 
-  test "runs Monty Python with JSON input and returns decoded output and stdout" do
+  test "runs Monty Python with JSON input and returns serialized output and stdout" do
     expect(Client, :connect, fn -> {:ok, :channel} end)
 
     expect(Stub, :run_python, fn :channel, request, opts ->
@@ -33,11 +33,13 @@ defmodule Console.AI.Tools.Workbench.PythonTest do
       {:ok, %RunPythonOutput{result_json: ~s({"total":42}), stdout: "calculated total\n"}}
     end)
 
-    assert {:ok, %{result: %{"total" => 42}, stdout: "calculated total\n"}} =
+    assert {:ok, output} =
              Python.implement(%Python{
                code: "output['total'] = input['first'] + input['second']",
                input: %{"first" => 20, "second" => 22}
              })
+
+    assert Jason.decode!(output) == %{"result" => %{"total" => 42}, "stdout" => "calculated total\n"}
   end
 
   test "defaults omitted input to an empty JSON object" do
@@ -48,6 +50,20 @@ defmodule Console.AI.Tools.Workbench.PythonTest do
       {:ok, %RunPythonOutput{result_json: "{}", stdout: ""}}
     end)
 
-    assert {:ok, %{result: %{}, stdout: ""}} = Python.implement(%Python{code: "output = {}"})
+    assert {:ok, output} = Python.implement(%Python{code: "output = {}"})
+    assert Jason.decode!(output) == %{"result" => %{}, "stdout" => ""}
+  end
+
+  test "bounds oversized Python output" do
+    expect(Client, :connect, fn -> {:ok, :channel} end)
+
+    expect(Stub, :run_python, fn :channel, _request, _opts ->
+      result = Jason.encode!(%{"value" => String.duplicate("x", Output.max_bytes())})
+      {:ok, %RunPythonOutput{result_json: result, stdout: ""}}
+    end)
+
+    assert {:ok, output} = Python.implement(%Python{code: "output = {}"})
+    assert byte_size(output) == Output.max_bytes()
+    assert output =~ "output truncated at 50 KiB"
   end
 end