Add rate limiter to helm agent fetches (#3893)

Author: michaeljguarino

.cursor/skills/console-tests/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: console-tests
-description: Run and interpret tests in the Console Elixir repo. Use when validating changes with `mix test`, running Docker integration tests, diagnosing sandbox network failures, or explaining Console test setup in Cursor.
+description: Run and interpret tests in the Console repo. Use when validating changes with `mix test`, running deployment-operator Go tests, diagnosing sandbox/toolchain/network failures, or explaining Console test setup in Cursor.
 ---
 
 # Console Tests
@@ -10,8 +10,19 @@ Use this skill when validating changes in the Console repo.
 ## Sandbox Requirements
 
 - Run `mix test` commands from the repo root: `/Users/michaelguarino/code/console`.
+- Run deployment-operator Go commands from `/Users/michaelguarino/code/console/go/deployment-operator`.
 - The default Cursor sandbox blocks some domains the Console app touches during startup and test aliases.
 - Use `required_permissions: ["full_network"]` for `mix test` runs that need the normal project setup.
+- For Go tests, explicitly set Go caches inside the workspace when running in the sandbox:
+
+```bash
+cd /Users/michaelguarino/code/console/go/deployment-operator && \
+GOPATH=/Users/michaelguarino/code/console/.go \
+GOCACHE=/Users/michaelguarino/code/console/.cache/go-build \
+go test ./pkg/controller/service
+```
+
+- Use `required_permissions: ["full_network"]` for Go tests when dependencies or the configured Go toolchain need to download. If Go still fails writing to `/Users/michaelguarino/go/pkg/...`, rerun with the in-workspace `GOPATH`/`GOCACHE` above before requesting `all`.
 - Do not run `mix format` in this repository.
 
 ## Why Full Network Is Needed
@@ -38,16 +49,36 @@ Full suite:
 mix test
 ```
 
+Focused deployment-operator service package:
+
+```bash
+cd /Users/michaelguarino/code/console/go/deployment-operator && \
+GOPATH=/Users/michaelguarino/code/console/.go \
+GOCACHE=/Users/michaelguarino/code/console/.cache/go-build \
+go test ./pkg/controller/service
+```
+
+Format changed deployment-operator Go files:
+
+```bash
+cd /Users/michaelguarino/code/console/go/deployment-operator && \
+gofmt -w pkg/controller/service/reconciler.go pkg/manifests/tarball.go
+```
+
 
 ## Interpreting Failures
 
 - A focused test passing is good validation for narrow changes, especially when the full suite is known to depend on external/local fixtures.
 - Full-suite failures like `could not resolve ref main` or `could not resolve ref master` usually indicate git fixture/ref setup problems unless the touched code is in that path.
+- Go failures like `go.work requires go >= 1.26.5` can mean the IDE/linter is using an older local Go. A shell `go test` may still work through Go's auto toolchain download when network and cache permissions are set correctly.
+- Sandbox errors writing under `/Users/michaelguarino/go/pkg/sumdb` indicate the Go module/toolchain cache is outside the writable workspace. Prefer setting `GOPATH` and `GOCACHE` inside `/Users/michaelguarino/code/console`.
 - Report full-suite failures honestly, but separate environment/fixture failures from failures in the files being changed.
 
 ## Validation Checklist
 
 - [ ] Run the most relevant focused test file with `full_network` if it uses project startup or external services.
+- [ ] For deployment-operator Go changes, run `gofmt -w` on touched files from the module directory.
+- [ ] For deployment-operator Go tests, `cd` into `go/deployment-operator` and use in-workspace `GOPATH`/`GOCACHE` when sandboxed.
 - [ ] Run the full suite with `full_network` when requested or when the change has broad impact.
 - [ ] Read the final ExUnit summary and any failure blocks for touched modules.
 - [ ] Run `ReadLints` on changed files after edits.

assets/src/components/commandpalette/commands.ts

@@ -1,6 +1,5 @@
 import {
   AiSparkleOutlineIcon,
-  BotIcon,
   CatalogIcon,
   ChatOutlineIcon,
   ClusterIcon,
@@ -190,28 +189,6 @@ export function useCommands({
                   deps: [setFeatureFlag],
                 },
               ]),
-          ...(!featureFlags.WorkbenchChatbots
-            ? [
-                {
-                  id: 'enable-workbench-chatbots',
-                  label: 'Enable Workbench Chatbots',
-                  icon: BotIcon,
-                  callback: () => setFeatureFlag('WorkbenchChatbots', true),
-                  deps: [setFeatureFlag],
-                },
-              ]
-            : []),
-          ...(featureFlags.WorkbenchChatbots
-            ? [
-                {
-                  id: 'disable-workbench-chatbots',
-                  label: 'Disable Workbench Chatbots',
-                  icon: BotIcon,
-                  callback: () => setFeatureFlag('WorkbenchChatbots', false),
-                  deps: [setFeatureFlag],
-                },
-              ]
-            : []),
           ...(openServiceAccountImpersonation
             ? [
                 {
@@ -226,7 +203,7 @@ export function useCommands({
         ],
       },
     ],
-    [featureFlags, openServiceAccountImpersonation, setFeatureFlag]
+    [featureFlags.Edge, openServiceAccountImpersonation, setFeatureFlag]
   )
 
   const commands = useMemo(

assets/src/components/flows/FeatureFlagContext.tsx

@@ -20,17 +20,14 @@ const defaultDocsUrl = 'https://docs.plural.sh/'
 
 export type FeatureFlags = {
   Edge: boolean
-  WorkbenchChatbots: boolean
 }
 
 const DEFAULT_FEATURE_FLAGS: FeatureFlags = {
   Edge: false,
-  WorkbenchChatbots: false,
 }
 
 const FEATURE_FLAG_LABELS: Record<keyof FeatureFlags, string> = {
   Edge: 'Edge',
-  WorkbenchChatbots: 'Workbench Chatbots',
 }
 
 export const FeatureFlagContext = createContext<{
@@ -79,7 +76,6 @@ export const FeatureFlagProvider = ({ children }: { children: ReactNode }) => {
         }}
       >
         {curType === 'Edge' && <EdgeBodyContent />}
-        {curType === 'WorkbenchChatbots' && <WorkbenchChatbotsBodyContent />}
       </FeatureFlagConfirmationModal>
       <Toast
         show={showToast}
@@ -175,12 +171,3 @@ function EdgeBodyContent() {
 function featureFlagLabel(type: keyof FeatureFlags | null) {
   return type ? FEATURE_FLAG_LABELS[type] : ''
 }
-
-function WorkbenchChatbotsBodyContent() {
-  return (
-    <span>
-      <strong>Workbench Chatbots</strong> is an experimental feature that lets
-      chat platforms trigger workbench runs.
-    </span>
-  )
-}

assets/src/components/workbenches/workbench/Workbench.tsx

@@ -23,7 +23,6 @@ import {
   WorkbenchTinyFragment,
 } from 'generated/graphql'
 import { GqlError } from 'components/utils/Alert'
-import { FeatureFlagContext } from 'components/flows/FeatureFlagContext'
 import { Confirm } from 'components/utils/Confirm'
 import { MoreMenu } from 'components/utils/MoreMenu'
 import { useSimpleToast } from 'components/utils/SimpleToastContext'
@@ -32,7 +31,7 @@ import { StretchedFlex } from 'components/utils/StretchedFlex'
 import { SubTabs } from 'components/utils/SubTabs'
 import { TRUNCATE } from 'components/utils/truncate'
 import { Subtitle2H1 } from 'components/utils/typography/Text'
-import { Key, ReactNode, use, useCallback, useMemo, useState } from 'react'
+import { Key, ReactNode, useCallback, useMemo, useState } from 'react'
 import { mapExistingNodes } from 'utils/graphql'
 import {
   Link,
@@ -111,7 +110,6 @@ export function WorkbenchPageLayout({
 }: WorkbenchPageLayoutProps) {
   const theme = useTheme()
   const navigate = useNavigate()
-  const { featureFlags } = use(FeatureFlagContext)
   const { workbenchId, isLoading, workbench, openToolsEdit, openDelete } =
     useOutletContext<WorkbenchOutletContext>()
 
@@ -175,7 +173,6 @@ export function WorkbenchPageLayout({
           navigate(getWorkbenchWebhookTriggersAbsPath(workbenchId))
           return
         case WorkbenchMoreMenuKey.Chatbots:
-          if (!featureFlags.WorkbenchChatbots) return
           navigate(getWorkbenchChatbotsAbsPath(workbenchId))
           return
         case WorkbenchMoreMenuKey.Tools:
@@ -194,14 +191,7 @@ export function WorkbenchPageLayout({
           return
       }
     },
-    [
-      navigate,
-      workbenchBasePath,
-      workbenchId,
-      openToolsEdit,
-      openDelete,
-      featureFlags.WorkbenchChatbots,
-    ]
+    [navigate, workbenchBasePath, workbenchId, openToolsEdit, openDelete]
   )
 
   return (
@@ -278,13 +268,11 @@ export function WorkbenchPageLayout({
                 leftContent={<WebhooksIcon />}
                 label="Webhook triggers"
               />
-              {featureFlags.WorkbenchChatbots && (
-                <ListBoxItem
-                  key={WorkbenchMoreMenuKey.Chatbots}
-                  leftContent={<BotIcon />}
-                  label="Chatbots"
-                />
-              )}
+              <ListBoxItem
+                key={WorkbenchMoreMenuKey.Chatbots}
+                leftContent={<BotIcon />}
+                label="Chatbots"
+              />
               <ListBoxItem
                 key={WorkbenchMoreMenuKey.SavedPrompts}
                 leftContent={<BookmarkIcon />}

assets/src/components/workbenches/workbench/WorkbenchSidePanel.tsx

@@ -6,9 +6,8 @@ import {
   PencilIcon,
 } from '@pluralsh/design-system'
 import { useWorkbenchTriggersSummaryQuery } from 'generated/graphql'
-import { FeatureFlagContext } from 'components/flows/FeatureFlagContext'
 import { isEmpty } from 'lodash'
-import { PropsWithChildren, use, useMemo } from 'react'
+import { PropsWithChildren, useMemo } from 'react'
 import { useNavigate } from 'react-router-dom'
 import styled from 'styled-components'
 import { mapExistingNodes } from 'utils/graphql'
@@ -36,7 +35,6 @@ export function WorkbenchSidePanel({
   onOpenToolsEdit: () => void
 }) {
   const navigate = useNavigate()
-  const { featureFlags } = use(FeatureFlagContext)
 
   const { data } = useWorkbenchTriggersSummaryQuery({
     variables: { id: workbenchId },
@@ -171,70 +169,68 @@ export function WorkbenchSidePanel({
             </ButtonSC>
           )}
         </SectionSC>
-        {featureFlags.WorkbenchChatbots && (
-          <SectionSC>
-            <HeaderSC>
-              <span>Chatbots</span>
-              {hasChatbots && (
-                <IconFrame
-                  clickable
-                  size="small"
-                  icon={<AddIcon size={12} />}
-                  tooltip="Add chatbot"
-                  onClick={() =>
-                    navigate(getWorkbenchChatbotCreateAbsPath(workbenchId))
-                  }
-                />
-              )}
-            </HeaderSC>
-            {hasChatbots ? (
-              <Flex
-                gap="xxsmall"
-                direction="column"
-              >
-                {chatbots.map((chatbot) => (
-                  <WorkbenchSidePanelEditRow
-                    key={chatbot.id}
-                    onClick={() =>
-                      navigate(
-                        getWorkbenchChatbotEditAbsPath({
-                          workbenchId,
-                          chatbotId: chatbot.id,
-                        })
-                      )
-                    }
-                  >
-                    <ItemIconContainerSC>
-                      <IconFrame
-                        icon={chatProviderConnectionIcon(
-                          chatbot.chatConnection?.type
-                        )}
-                        size="xsmall"
-                      />
-                    </ItemIconContainerSC>
-                    <ItemNameSC>
-                      {formatChatbotChannelLabel({
-                        type: chatbot.chatConnection?.type,
-                        channel: chatbot.channel,
-                      })}
-                    </ItemNameSC>
-                  </WorkbenchSidePanelEditRow>
-                ))}
-              </Flex>
-            ) : (
-              <ButtonSC
-                small
-                startIcon={<AddIcon size={12} />}
-                tertiary
+        <SectionSC>
+          <HeaderSC>
+            <span>Chatbots</span>
+            {hasChatbots && (
+              <IconFrame
+                clickable
+                size="small"
+                icon={<AddIcon size={12} />}
+                tooltip="Add chatbot"
                 onClick={() =>
                   navigate(getWorkbenchChatbotCreateAbsPath(workbenchId))
                 }
-              >
-                Add chatbot
-              </ButtonSC>
+              />
             )}
-          </SectionSC>
-        )}
+          </HeaderSC>
+          {hasChatbots ? (
+            <Flex
+              gap="xxsmall"
+              direction="column"
+            >
+              {chatbots.map((chatbot) => (
+                <WorkbenchSidePanelEditRow
+                  key={chatbot.id}
+                  onClick={() =>
+                    navigate(
+                      getWorkbenchChatbotEditAbsPath({
+                        workbenchId,
+                        chatbotId: chatbot.id,
+                      })
+                    )
+                  }
+                >
+                  <ItemIconContainerSC>
+                    <IconFrame
+                      icon={chatProviderConnectionIcon(
+                        chatbot.chatConnection?.type
+                      )}
+                      size="xsmall"
+                    />
+                  </ItemIconContainerSC>
+                  <ItemNameSC>
+                    {formatChatbotChannelLabel({
+                      type: chatbot.chatConnection?.type,
+                      channel: chatbot.channel,
+                    })}
+                  </ItemNameSC>
+                </WorkbenchSidePanelEditRow>
+              ))}
+            </Flex>
+          ) : (
+            <ButtonSC
+              small
+              startIcon={<AddIcon size={12} />}
+              tertiary
+              onClick={() =>
+                navigate(getWorkbenchChatbotCreateAbsPath(workbenchId))
+              }
+            >
+              Add chatbot
+            </ButtonSC>
+          )}
+        </SectionSC>
         <SectionSC>
           <HeaderSC>
             <span>Cron schedules</span>

charts/console/templates/deployment.yaml

@@ -8,6 +8,10 @@ metadata:
 {{ include "console.labels" . | indent 4 }}
 spec:
   replicas: {{ .Values.replicaCount }}
+  {{- if .Values.strategy }}
+  strategy:
+    {{- toYaml .Values.strategy | nindent 4 }}
+  {{- end }}
   selector:
     matchLabels:
       app.kubernetes.io/name: console

charts/console/templates/migration.yaml

@@ -43,6 +43,8 @@ spec:
             name: console-migration-env
         env:
         {{ include "console.env" . | nindent 8 }}
+        - name: DB_POOL_TARGET
+          value: '1000'
         {{- if  .Values.extraEnv }}
         {{- toYaml .Values.extraEnv | nindent 8 }}
         {{- end }}