Skip to content

Commit f68b236

Browse files
Fix /ping endpoint intermittent 500 errors
Remove conditional exception that caused /ping to fail when time.time() % 3 == 0. Health check endpoints should be deterministic and always succeed. Add test coverage for /ping endpoint.
1 parent 12f5d2d commit f68b236

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

app/main.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212

1313
@app.get("/ping")
1414
def test():
15-
if int(time.time()) % 3 == 0:
16-
raise Exception("unknown internal error")
17-
1815
return {"pong": True}
1916

2017
@app.get("/hello")

app/test_main.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,8 @@
77
def test_read_root():
88
response = client.get("/")
99
assert response.status_code == 200
10+
11+
def test_ping():
12+
response = client.get("/ping")
13+
assert response.status_code == 200
14+
assert response.json() == {"pong": True}

0 commit comments

Comments
 (0)