Revert "Skipping empty string in update expressions as it used to convert to … (adjoeio#28)"

This reverts commit 7fec125.

Author: chatenilesh

dynamo_repository.go

@@ -109,9 +109,6 @@ func (repository Repository) UpdateWithContext(ctx context.Context, expression U
 	}
 
 	for expr, value := range values {
-		if isEmptyString(value) {
-			continue
-		}
 		if expression == Add {
 			update.Add(expr, value)
 		}
@@ -162,9 +159,6 @@ func (repository Repository) prepareUpdateWithUpdateExpressions(
 		expression := UpdateExpression(updateExpression)
 
 		for expr, value := range v {
-			if isEmptyString(value) {
-				continue
-			}
 			if expression == Add {
 				update.Add(expr, value)
 			}

helper.go

@@ -13,11 +13,6 @@ func valueFromPtr[T any](ptr *T) T {
 	return *ptr
 }
 
-func isEmptyString(value any) bool {
-	str, ok := value.(string)
-	return ok && str == ""
-}
-
 func buildTableKeyCondition(table dynamo.Table, key KeyInterface) *dynamo.Query {
 	q := table.Get(*key.HashKeyName(), key.HashKey())
 

key.go

@@ -100,8 +100,5 @@ func isValidHashKey(key KeyInterface) error {
 	if key.HashKey() == nil {
 		return ErrInvalidHashKeyValue
 	}
-	if str, ok := key.HashKey().(string); ok && str == "" {
-		return ErrInvalidHashKeyValue
-	}
 	return nil
 }

repository_update_test.go

@@ -67,17 +67,6 @@ var _ = Describe("Repository", func() {
 					"TraceID":  "name4",
 				}
 
-				err := repository.UpdateWithContext(context.Background(), djoemo.Set, key, updates)
-				Expect(err).To(Equal(djoemo.ErrInvalidHashKeyValue))
-			})
-			It("should fail with hash key value is empty string", func() {
-				key := djoemo.Key().WithTableName(UserTableName).WithHashKeyName("UUID").WithHashKey("")
-				metricsMock.EXPECT().Record(gomock.Any(), djoemo.OpUpdate, key, gomock.Any(), false)
-				updates := map[string]interface{}{
-					"UserName": "name2",
-					"TraceID":  "name4",
-				}
-
 				err := repository.UpdateWithContext(context.Background(), djoemo.Set, key, updates)
 				Expect(err).To(Equal(djoemo.ErrInvalidHashKeyValue))
 			})
@@ -109,54 +98,6 @@ var _ = Describe("Repository", func() {
 			Expect(err).To(BeNil())
 		})
 
-		It("should skip empty string values in Set update", func() {
-			key := djoemo.Key().WithTableName(UserTableName).
-				WithHashKeyName("UUID").
-				WithHashKey("uuid")
-
-			dMock.Should().Update(
-				dMock.WithTable(key.TableName()),
-				dMock.WithMatch(
-					mock.InputExpect().
-						FieldEq("UserName", "name2"),
-				),
-			).Exec()
-
-			metricsMock.EXPECT().Record(gomock.Any(), djoemo.OpUpdate, key, gomock.Any(), true)
-
-			updates := map[string]interface{}{
-				"UserName": "name2",
-				"DeviceID": "",
-			}
-
-			err := repository.UpdateWithContext(context.Background(), djoemo.Set, key, updates)
-			Expect(err).To(BeNil())
-		})
-
-		It("should skip empty string values in SetIfNotExists update", func() {
-			key := djoemo.Key().WithTableName(UserTableName).
-				WithHashKeyName("UUID").
-				WithHashKey("uuid")
-
-			dMock.Should().Update(
-				dMock.WithTable(key.TableName()),
-				dMock.WithMatch(
-					mock.InputExpect().
-						FieldEq("SDKHash", "hash123"),
-				),
-			).Exec()
-
-			metricsMock.EXPECT().Record(gomock.Any(), djoemo.OpUpdate, key, gomock.Any(), true)
-
-			updates := map[string]interface{}{
-				"SDKHash":    "hash123",
-				"DeviceName": "",
-			}
-
-			err := repository.UpdateWithContext(context.Background(), djoemo.SetIfNotExists, key, updates)
-			Expect(err).To(BeNil())
-		})
-
 		It("should Update item with SetSet", func() {
 			key := djoemo.Key().WithTableName(UserTableName).
 				WithHashKeyName("UUID").
@@ -274,82 +215,6 @@ var _ = Describe("Repository", func() {
 		})
 	})
 
-	Describe("UpdateWithUpdateExpressions", func() {
-		It("should update item with mixed Set and SetIfNotExists expressions", func() {
-			key := djoemo.Key().WithTableName(UserTableName).
-				WithHashKeyName("UUID").
-				WithHashKey("uuid")
-
-			dMock.Should().Update(
-				dMock.WithTable(key.TableName()),
-				dMock.WithMatch(
-					mock.InputExpect().
-						FieldEq("UserName", "name2").FieldEq("SDKHash", "hash123"),
-				),
-			).Exec()
-
-			metricsMock.EXPECT().Record(gomock.Any(), djoemo.OpUpdate, key, gomock.Any(), true)
-
-			updateExpressions := djoemo.UpdateExpressions{
-				djoemo.Set: {
-					"UserName": "name2",
-				},
-				djoemo.SetIfNotExists: {
-					"SDKHash": "hash123",
-				},
-			}
-
-			err := repository.UpdateWithUpdateExpressions(context.Background(), key, updateExpressions)
-			Expect(err).To(BeNil())
-		})
-
-		It("should fail with hash key value is empty string", func() {
-			key := djoemo.Key().WithTableName(UserTableName).WithHashKeyName("UUID").WithHashKey("")
-			metricsMock.EXPECT().Record(gomock.Any(), djoemo.OpUpdate, key, gomock.Any(), false)
-
-			updateExpressions := djoemo.UpdateExpressions{
-				djoemo.Set: {
-					"UserName": "name2",
-				},
-			}
-
-			err := repository.UpdateWithUpdateExpressions(context.Background(), key, updateExpressions)
-			Expect(err).To(Equal(djoemo.ErrInvalidHashKeyValue))
-		})
-
-		It("should skip empty string values in Set and SetIfNotExists expressions", func() {
-			key := djoemo.Key().WithTableName(UserTableName).
-				WithHashKeyName("UUID").
-				WithHashKey("uuid")
-
-			dMock.Should().Update(
-				dMock.WithTable(key.TableName()),
-				dMock.WithMatch(
-					mock.InputExpect().
-						FieldEq("UserName", "name2").FieldEq("SDKHash", "hash123"),
-				),
-			).Exec()
-
-			metricsMock.EXPECT().Record(gomock.Any(), djoemo.OpUpdate, key, gomock.Any(), true)
-
-			updateExpressions := djoemo.UpdateExpressions{
-				djoemo.Set: {
-					"UserName":    "name2",
-					"DeviceID":    "",
-					"ProductName": "",
-				},
-				djoemo.SetIfNotExists: {
-					"SDKHash":    "hash123",
-					"DeviceName": "",
-					"DeviceType": "",
-				},
-			}
-
-			err := repository.UpdateWithUpdateExpressions(context.Background(), key, updateExpressions)
-			Expect(err).To(BeNil())
-		})
-	})
-
 	Describe("UpdateItem with condition", func() {
 		It("should save an item if the condition is met", func() {
 			key := djoemo.Key().WithTableName(UserTableName).