Proposed changes

Writing this on my phone, apologies for anything I miss and any name errors.

This PR introduces functionality to translate physical names from ‘’.msh’’ files to tags in the sense of ‘’pp.Grid.tags’’. This allows, e.g., to easily recreate the geometry of SPE11 by loading the grid and assigning permeability and porosity based on tags.

Porepy offers functionality to import from ‘.msh’ files via ‘’pp.fracs.fracture_importer. dfm_from_gmsh’’. At some point in the process, ‘’pp.fracs.msh_2_grid.create_nd_grids’’ is called to create nd subdomain grids.

We introduce a helper function ‘’tag_grids’’ which takes the information available to ‘’create_nd_grids’’ and the created subdomain grid and updates ‘‘grid.tags’’ accordingly. The function is called by every ‘’create_nd_grids’’ at the very end.

So far done:

• Write ‘’tag_grids’’
• Include ‘’tag_grids’’ in ‘’create_nd_grids’’
• Write a test for ‘’tag_grids’’
• Write tests for ‘’create_nd_grids’’. These test only the tagging

ToDo:

• Pass the correct input to ‘’create_nd_grids’’. The way we try to do this is by meshing with ‘’fracture_network.mesh’’ and reading the created file. However this does not include physical names nor does it assign any physical names to mesh entities (vertices, lines, triangles, tetrahedra). The way we planned to do this is to loop through the file and add the correct lines manually. This is quite challenging. Possibly this whole approach has to be changed.

Hope this gives a good overview, let us know if you need more info

Types of changes

• Minor change (e.g., dependency bumps, broken links).
• Bugfix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).
• Testing (contribution related to testing of existing or new functionality).
• Documentation (contribution related to adding, improving, or fixing documentation).
• Maintenance (e.g., improve logic and performance, remove obsolete code).
• Other:

Checklist

• The documentation is up-to-date.
• Static typing is included in the update.
• This PR does not duplicate existing functionality.
• The update is covered by the test suite (including tests added in the PR).
• If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.