phpstan generics are so buggy :(

Author: dktapps

composer.json

@@ -8,7 +8,7 @@
         "pocketmine/binaryutils": "^0.2.0"
     },
     "require-dev": {
-        "phpstan/phpstan": "2.1.0",
+        "phpstan/phpstan": "2.1.27",
         "phpunit/phpunit": "^9.5",
         "phpstan/extension-installer": "^1.0",
         "phpstan/phpstan-strict-rules": "^2.0",

src/tag/ListTag.php

@@ -91,9 +91,7 @@ public function getAllValues() : array{
 	 * @phpstan-this-out self<TTarget> $this
 	 */
 	private function checkTagClass(string $tagClass) : bool{
-		return $this->value->isEmpty() ?
-			$this->tagType === NBT::TAG_End :
-			$this->first() instanceof $tagClass;
+		return count($this->value) === 0 || $this->first() instanceof $tagClass;
 	}
 
 	/**
@@ -124,7 +122,9 @@ public function getCount() : int{
 	/**
 	 * Appends the specified tag to the end of the list.
 	 *
-	 * @phpstan-param TValue $tag
+	 * @phpstan-template TNewValue of TValue
+	 * @phpstan-param TNewValue $tag
+	 * @phpstan-this-out self<TNewValue>
 	 */
 	public function push(Tag $tag) : void{
 		$this->checkTagType($tag);
@@ -145,7 +145,9 @@ public function pop() : Tag{
 	/**
 	 * Adds the specified tag to the start of the list.
 	 *
-	 * @phpstan-param TValue $tag
+	 * @phpstan-template TNewValue of TValue
+	 * @phpstan-param TNewValue $tag
+	 * @phpstan-this-out self<TNewValue>
 	 */
 	public function unshift(Tag $tag) : void{
 		$this->checkTagType($tag);
@@ -167,7 +169,9 @@ public function shift() : Tag{
 	 * Inserts a tag into the list between existing tags, at the specified offset. Later values in the list are moved up
 	 * by 1 position.
 	 *
-	 * @phpstan-param TValue $tag
+	 * @phpstan-template TNewValue of TValue
+	 * @phpstan-param TNewValue $tag
+	 * @phpstan-this-out self<TNewValue>
 	 *
 	 * @return void
 	 * @throws \OutOfRangeException if the offset is not within the bounds of the list
@@ -232,7 +236,9 @@ public function last() : Tag{
 	/**
 	 * Overwrites the tag at the specified offset.
 	 *
-	 * @phpstan-param TValue $tag
+	 * @phpstan-template TNewValue of TValue
+	 * @phpstan-param TNewValue $tag
+	 * @phpstan-this-out self<TNewValue>
 	 *
 	 * @throws \OutOfRangeException if the offset is not within the bounds of the list
 	 */

src/tag/Tag.php

@@ -57,6 +57,7 @@ abstract protected function stringifyValue(int $indentation) : string;
 	 * Used for cloning tags in tags that have children.
 	 *
 	 * @throws \RuntimeException if a recursive dependency was detected
+	 * @return static
 	 */
 	public function safeClone() : Tag{
 		if($this->cloning){

tests/phpstan/configs/phpstan-bugs.neon

@@ -13,13 +13,37 @@ parameters:
 			path: ../../../src/tag/IntArrayTag.php
 
 		-
-			message: '#^Property pocketmine\\nbt\\tag\\ListTag\:\:\$value \(list\<pocketmine\\nbt\\tag\\Tag\>\) does not accept non\-empty\-array\<int\<0, max\>, pocketmine\\nbt\\tag\\Tag\>\.$#'
+			message: '#^Property pocketmine\\nbt\\tag\\ListTag\<TValue of pocketmine\\nbt\\tag\\Tag \= pocketmine\\nbt\\tag\\Tag\>\:\:\$value \(list\<TValue of pocketmine\\nbt\\tag\\Tag \= pocketmine\\nbt\\tag\\Tag\>\) does not accept non\-empty\-array\<int\<0, max\>, \(TNewValue of TValue of pocketmine\\nbt\\tag\\Tag \= pocketmine\\nbt\\tag\\Tag\)\|TValue of pocketmine\\nbt\\tag\\Tag \= pocketmine\\nbt\\tag\\Tag\>\.$#'
 			identifier: assign.propertyType
 			count: 1
 			path: ../../../src/tag/ListTag.php
 
+		-
+			message: '#^Property pocketmine\\nbt\\tag\\ListTag\<TValue of pocketmine\\nbt\\tag\\Tag \= pocketmine\\nbt\\tag\\Tag\>\:\:\$value \(list\<TValue of pocketmine\\nbt\\tag\\Tag \= pocketmine\\nbt\\tag\\Tag\>\) does not accept non\-empty\-list\<\(TNewValue of TValue of pocketmine\\nbt\\tag\\Tag \= pocketmine\\nbt\\tag\\Tag\)\|TValue of pocketmine\\nbt\\tag\\Tag \= pocketmine\\nbt\\tag\\Tag\>\.$#'
+			identifier: assign.propertyType
+			count: 3
+			path: ../../../src/tag/ListTag.php
+
 		-
 			message: '#^Call to function is_string\(\) with string will always evaluate to true\.$#'
 			identifier: function.alreadyNarrowedType
 			count: 1
 			path: ../../phpunit/tag/CompoundTagTest.php
+
+		-
+			message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertNotSame\(\) with \*NEVER\* and pocketmine\\nbt\\tag\\Tag will always evaluate to true\.$#'
+			identifier: staticMethod.alreadyNarrowedType
+			count: 1
+			path: ../../phpunit/tag/ListTagTest.php
+
+		-
+			message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertSame\(\) with \*NEVER\* and pocketmine\\nbt\\tag\\Tag will always evaluate to false\.$#'
+			identifier: staticMethod.impossibleType
+			count: 1
+			path: ../../phpunit/tag/ListTagTest.php
+
+		-
+			message: '#^Instanceof between \*NEVER\* and pocketmine\\nbt\\tag\\ImmutableTag will always evaluate to false\.$#'
+			identifier: instanceof.alwaysFalse
+			count: 1
+			path: ../../phpunit/tag/ListTagTest.php