Added unit test for empty ListTag type preservation

Author: dktapps

tests/phpunit/tag/ListTagTest.php

@@ -24,7 +24,9 @@
 namespace pocketmine\nbt\tag;
 
 use PHPUnit\Framework\TestCase;
+use pocketmine\nbt\BigEndianNbtSerializer;
 use pocketmine\nbt\NBT;
+use pocketmine\nbt\TreeRoot;
 use function array_fill;
 use function array_key_first;
 use function array_keys;
@@ -145,4 +147,19 @@ public function testDelete() : void{
 		self::assertSame([0, 2], $list->getAllValues());
 		self::assertSame([0, 1], array_keys($list->getValue()));
 	}
+
+	/**
+	 * Tests that empty lists remember their original type from deserialization
+	 * Previously we were discarding these, creating problems for read/write integrity testing
+	 */
+	public function testEmptyBinarySymmetry() : void{
+		$list = new ListTag([], NBT::TAG_Byte);
+
+		$serializer = new BigEndianNbtSerializer();
+		$list2 = $serializer->read($serializer->write(new TreeRoot($list)))->getTag();
+
+		self::assertInstanceOf(ListTag::class, $list2);
+		self::assertSame($list->getTagType(), $list2->getTagType());
+		self::assertSame($list->getCount(), $list2->getCount());
+	}
 }