change error identifier

Author: dktapps

tests/phpstan/configs/actual-problems.neon

@@ -20,7 +20,7 @@ parameters:
 
 		-
 			message: '#^Dynamic new is not allowed\.$#'
-			identifier: pocketmine.new.noDynamic
+			identifier: pocketmine.new.dynamic
 			count: 1
 			path: ../../../src/Server.php
 
@@ -62,7 +62,7 @@ parameters:
 
 		-
 			message: '#^Dynamic new is not allowed\.$#'
-			identifier: pocketmine.new.noDynamic
+			identifier: pocketmine.new.dynamic
 			count: 1
 			path: ../../../src/block/Block.php
 
@@ -524,7 +524,7 @@ parameters:
 
 		-
 			message: '#^Dynamic new is not allowed\.$#'
-			identifier: pocketmine.new.noDynamic
+			identifier: pocketmine.new.dynamic
 			count: 1
 			path: ../../../src/block/tile/TileFactory.php
 
@@ -956,7 +956,7 @@ parameters:
 
 		-
 			message: '#^Dynamic new is not allowed\.$#'
-			identifier: pocketmine.new.noDynamic
+			identifier: pocketmine.new.dynamic
 			count: 1
 			path: ../../../src/plugin/PluginManager.php
 
@@ -1274,7 +1274,7 @@ parameters:
 
 		-
 			message: '#^Dynamic new is not allowed\.$#'
-			identifier: pocketmine.new.noDynamic
+			identifier: pocketmine.new.dynamic
 			count: 1
 			path: ../../../src/world/generator/GeneratorRegisterTask.php
 

tests/phpstan/rules/DisallowDynamicNewRule.php

@@ -45,7 +45,7 @@ public function processNode(Node $node, Scope $scope) : array{
 			return [
 				RuleErrorBuilder::message("Dynamic new is not allowed.")
 					->tip("For factories, use closures instead. Closures can implement custom logic, are statically analyzable, and don't restrict the constructor signature.")
-					->identifier("pocketmine.new.noDynamic")
+					->identifier("pocketmine.new.dynamic")
 					->build()
 			];
 		}