Fixed not encoding ACKs

dktapps · dktapps · commit d47138390d20 · 2025-09-10T17:51:06.000+01:00
diff --git a/src/protocol/AcknowledgePacket.php b/src/protocol/AcknowledgePacket.php
@@ -34,7 +34,6 @@ abstract class AcknowledgePacket extends Packet{
 	public array $packets = [];
 
 	protected function encodePayload(ByteBufferWriter $out) : void{
-		$payload = "";
 		$subWriter = new ByteBufferWriter();
 		sort($this->packets, SORT_NUMERIC);
 		$count = count($this->packets);
@@ -77,7 +76,7 @@ protected function encodePayload(ByteBufferWriter $out) : void{
 		}
 
 		BE::writeUnsignedShort($out, $records);
-		$out->writeByteArray($payload);
+		$out->writeByteArray($subWriter->getData());
 	}
 
 	protected function decodePayload(ByteBufferReader $in) : void{

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ abstract class AcknowledgePacket extends Packet{`
`34`	`34`	`public array $packets = [];`
`35`	`35`
`36`	`36`	`protected function encodePayload(ByteBufferWriter $out) : void{`
`37`		`- $payload = "";`
`38`	`37`	`$subWriter = new ByteBufferWriter();`
`39`	`38`	`sort($this->packets, SORT_NUMERIC);`
`40`	`39`	`$count = count($this->packets);`
`@@ -77,7 +76,7 @@ protected function encodePayload(ByteBufferWriter $out) : void{`
`77`	`76`	`}`
`78`	`77`
`79`	`78`	`BE::writeUnsignedShort($out, $records);`
`80`		`- $out->writeByteArray($payload);`
	`79`	`+ $out->writeByteArray($subWriter->getData());`
`81`	`80`	`}`
`82`	`81`
`83`	`82`	`protected function decodePayload(ByteBufferReader $in) : void{`