Skip to content

Update @types/three to enable WebGLProgramParametersWithUniforms type #2514

@creativoma

Description

@creativoma

Describe the feature you'd like:

Update @types/three from version 0.159.0 to 0.161.0+ to enable proper TypeScript typing in multiple files. There are currently 3 FIXME comments in the codebase waiting for this update to use THREE.WebGLProgramParametersWithUniforms type.

Current situation:

Affected files:

  • src/core/MeshDistortMaterial.tsx:25
  • src/core/MeshWobbleMaterial.tsx:21
  • src/core/useBoxProjectedEnv.tsx:52

All have the same FIXME comment:

// FIXME Use `THREE.WebGLProgramParametersWithUniforms` type when able to target @types/[email protected]

Benefits:

  • Better TypeScript support
  • Cleaner code without FIXME comments
  • Improved type safety

Suggested implementation:

  1. Update @types/three to version 0.161.0 or higher in package.json
  2. Replace the FIXME comments with proper typing using THREE.WebGLProgramParametersWithUniforms
  3. Update the method signatures in the affected files
  4. Test that everything still works correctly

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions