-
Notifications
You must be signed in to change notification settings - Fork 773
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Describe the feature you'd like:
Update @types/three
from version 0.159.0 to 0.161.0+ to enable proper TypeScript typing in multiple files. There are currently 3 FIXME comments in the codebase waiting for this update to use THREE.WebGLProgramParametersWithUniforms
type.
Current situation:
- Current version:
@types/[email protected]
- Target version:
@types/[email protected]+
Affected files:
src/core/MeshDistortMaterial.tsx:25
src/core/MeshWobbleMaterial.tsx:21
src/core/useBoxProjectedEnv.tsx:52
All have the same FIXME comment:
// FIXME Use `THREE.WebGLProgramParametersWithUniforms` type when able to target @types/[email protected]
Benefits:
- Better TypeScript support
- Cleaner code without FIXME comments
- Improved type safety
Suggested implementation:
- Update
@types/three
to version 0.161.0 or higher inpackage.json
- Replace the FIXME comments with proper typing using
THREE.WebGLProgramParametersWithUniforms
- Update the method signatures in the affected files
- Test that everything still works correctly
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request