v5 shallow cares about set order.

[lakardion]

Bug Description

Hello there. I was just playing around with this and noticed that the new shallow returns false for two sets that have the same elements inside.

import { shallow } from "zustand/shallow";

const firstArray = [1, 2, 3];
const myFirstSet = new Set(firstArray);
const secondArray = [2, 1, 3];
const mySecondSet = new Set(secondArray);

console.log({
  myFirstSet,
  mySecondSet,
});

// v5 shallow returns false
const result = shallow(myFirstSet, mySecondSet);

Created two sandboxes as well to showcase that the previous version was returning true
v4 shallow:
https://codesandbox.io/p/sandbox/m8lkgp
v5 shallow
https://codesandbox.io/p/sandbox/shallow-check-zustand-zkjy77

Reproduction Link

https://codesandbox.io/p/sandbox/shallow-check-zustand-zkjy77

[dbritto-dev]

@lakardion thanks, I'll take care of that

[lakardion]

This looks good to me @dbritto-dev 🚀 !

[dbritto-dev]

@dai-shi any thoughts?

[dai-shi]

It seems very different from the current implementation. Does it pass all the tests? In any case, my idea to implement this is slightly different.

[dbritto-dev]

@dai-shi let me run some tests

[dbritto-dev]

@dai-shi #2816