Merge pull request #174 from pneumaticapp/backend/notifications/44797__email_notifications_not_sent_group_user

44797 backend [ notifications ] "Overdue task" email is not sent if the assigning user belongs to a group.

Author: EBirkenfeld

backend/src/notifications/queries.py

@@ -6,7 +6,6 @@
 from src.generics.mixins.queries import DereferencedPerformersMixin
 from src.notifications.enums import NotificationMethod
 from src.processes.enums import (
-    DirectlyStatus,
     TaskStatus,
     WorkflowStatus,
 )
@@ -17,7 +16,7 @@
 UserModel = get_user_model()
 
 
-class UsersWithOverdueTaskQuery(SqlQueryObject):
+class UsersWithOverdueTaskQuery(SqlQueryObject, DereferencedPerformersMixin):
 
     def get_sql(self) -> Tuple[str, dict]:
         return f"""
@@ -64,22 +63,23 @@ def get_sql(self) -> Tuple[str, dict]:
             INNER JOIN processes_task pt
               ON pw.id = pt.workflow_id
               AND pt.status = '{TaskStatus.ACTIVE}'
-            INNER JOIN processes_taskperformer ptp
-              ON pt.id = ptp.task_id
+            INNER JOIN (
+              {self.all_dereferenced_performers()}
+            ) dereferenced_performers
+              ON pt.id = dereferenced_performers.task_id
             INNER JOIN accounts_user au
-              ON au.id = ptp.user_id
+              ON au.id = dereferenced_performers.user_id
             INNER JOIN accounts_account aa
               ON au.account_id = aa.id
             LEFT JOIN accounts_notification an
               ON an.task_id = pt.id
-              AND an.user_id = ptp.user_id
+              AND an.user_id = dereferenced_performers.user_id
               AND an.type = '{NotificationType.OVERDUE_TASK}'
             WHERE pt.is_deleted is FALSE
               AND pw.status = '{WorkflowStatus.RUNNING}'
               AND pt.due_date IS NOT NULL
               AND pt.due_date <= NOW()
-              AND ptp.is_completed IS FALSE
-              AND ptp.directly_status != '{DirectlyStatus.DELETED}'
+              AND dereferenced_performers.is_completed IS FALSE
               AND au.status = '{UserStatus.ACTIVE}'
         ) result INNER JOIN accounts_user au
           ON au.id = result.workflow_starter_id

backend/src/notifications/tests/test_tasks/test_send_overdue_task_notification.py

@@ -23,11 +23,15 @@
 from src.processes.enums import (
     DirectlyStatus,
     WorkflowStatus,
+    PerformerType,
 )
 from src.processes.models.workflows.task import TaskPerformer
 from src.processes.tests.fixtures import (
     create_test_account,
+    create_test_admin,
     create_test_guest,
+    create_test_group,
+    create_test_owner,
     create_test_user,
     create_test_workflow,
 )
@@ -666,3 +670,58 @@ def test_send_overdue_task_notification__completed_performer__skip(mocker):
         token=None,
         link=link,
     )
+
+
+def test_send_overdue_task_notification__group_performer__ok(mocker):
+
+    # arrange
+    user = create_test_owner()
+    group_user = create_test_admin(account=user.account)
+    group = create_test_group(user.account, users=[group_user])
+
+    workflow = create_test_workflow(user, tasks_count=1)
+    task = workflow.tasks.get(number=1)
+    task.taskperformer_set.all().delete()
+    TaskPerformer.objects.create(
+        task=task,
+        group=group,
+        type=PerformerType.GROUP,
+    )
+    task.due_date = timezone.now() - timedelta(minutes=5)
+    task.save(update_fields=['due_date'])
+    send_notification_mock = mocker.patch(
+        'src.notifications.tasks._send_notification',
+    )
+
+    # act
+    _send_overdue_task_notification()
+
+    # assert
+    notification = Notification.objects.get(
+        task_id=task.id,
+        user_id=group_user.id,
+        type=NotificationType.OVERDUE_TASK,
+        status=NotificationStatus.NEW,
+    )
+    link = f'{settings.FRONTEND_URL}/tasks/{task.id}'
+    send_notification_mock.assert_called_once_with(
+        logging=user.account.log_api_requests,
+        method_name=NotificationMethod.overdue_task,
+        account_id=group_user.account_id,
+        user_id=group_user.id,
+        user_type=group_user.type,
+        user_email=group_user.email,
+        logo_lg=None,
+        task_id=task.id,
+        task_name=task.name,
+        workflow_id=workflow.id,
+        workflow_name=workflow.name,
+        template_name=workflow.template.name,
+        workflow_starter_id=workflow.workflow_starter_id,
+        workflow_starter_first_name=user.first_name,
+        workflow_starter_last_name=user.last_name,
+        notification=notification,
+        sync=True,
+        token=None,
+        link=link,
+    )