Merge pull request #200 from pneumaticapp/backend/workflow/45866__skip_task_if_workflow_starter

45866 backend [ workflow ] Skip task if workflow starter is a performer

Author: EBirkenfeld

backend/src/processes/migrations/0251_add_skip_for_starter.py

@@ -0,0 +1,23 @@
+# Generated by Django 2.2 on 2026-04-10 15:01
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('processes', '0250_workflowevent_type_add_task_delegated'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='task',
+            name='skip_for_starter',
+            field=models.BooleanField(default=False),
+        ),
+        migrations.AddField(
+            model_name='tasktemplate',
+            name='skip_for_starter',
+            field=models.BooleanField(default=False),
+        ),
+    ]

backend/src/processes/models/mixins.py

@@ -162,6 +162,7 @@ class Meta:
         validators=[MinValueValidator(1)],
     )
     require_completion_by_all = models.BooleanField(default=False)
+    skip_for_starter = models.BooleanField(default=False)
     revert_task = models.CharField(
         max_length=255,
         null=True,

backend/src/processes/serializers/templates/task.py

@@ -71,6 +71,7 @@ class Meta:
             'number',
             'description',
             'require_completion_by_all',
+            'skip_for_starter',
             'delay',
             'fields',
             'conditions',
@@ -87,6 +88,7 @@ class Meta:
             'number',
             'description',
             'require_completion_by_all',
+            'skip_for_starter',
             'delay',
             'api_name',
             'template',

backend/src/processes/services/tasks/task.py

@@ -82,6 +82,7 @@ def _create_instance(
             require_completion_by_all=(
                 instance_template.require_completion_by_all
             ),
+            skip_for_starter=instance_template.skip_for_starter,
             is_urgent=workflow.is_urgent,
             checklists_total=ChecklistTemplateSelection.objects.filter(
                 checklist__task=instance_template,

backend/src/processes/services/tasks/task_version.py

@@ -241,6 +241,7 @@ def _create_or_update_instance(
             'require_completion_by_all': data[
                 'require_completion_by_all'
             ],
+            'skip_for_starter': data['skip_for_starter'],
             'name_template': data['name'],
             'name': insert_fields_values_to_text(
                 text=data['name'],

backend/src/processes/services/versioning/schemas.py

@@ -191,6 +191,7 @@ class Meta:
             'clear_description',
             'number',
             'require_completion_by_all',
+            'skip_for_starter',
             'fields',
             'delay',
             'conditions',

backend/src/processes/services/workflow_action.py

@@ -464,6 +464,20 @@ def continue_task(self, task: Task, is_returned: bool = False):
             .by_workflow(self.workflow.id).with_tasks_after(task)
             .update(is_completed=False, date_completed=None)
         )
+        if task.skip_for_starter and task.require_completion_by_all:
+            starter = self.workflow.workflow_starter
+            if starter:
+                (
+                    TaskPerformer.objects
+                    .by_task(task.id)
+                    .exclude_directly_deleted()
+                    .by_user_or_group(starter.id)
+                    .update(
+                        is_completed=True,
+                        date_completed=timezone.now(),
+                    )
+                )
+
         # if task force snoozed then start task event already exists
         # but if task returned then
         if not task_start_event_already_exist:
@@ -479,6 +493,7 @@ def continue_task(self, task: Task, is_returned: bool = False):
                 TaskPerformer.objects
                 .by_task(task.id)
                 .exclude_directly_deleted()
+                .not_completed()
                 .get_user_ids_emails_subscriber_set()
             )
 
@@ -615,6 +630,21 @@ def delay_task(self, task: Task, delay: Delay):
             delay=delay,
         )
 
+    def _skip_task_for_starter(
+        self,
+        task: Task,
+        is_returned: bool,
+    ):
+        WorkflowEventService.task_skip_event(task)
+        if is_returned and task.parents:
+            task.status = TaskStatus.PENDING
+            task.save(update_fields=['status'])
+            self._start_prev_tasks(task)
+        else:
+            task.status = TaskStatus.SKIPPED
+            task.save(update_fields=['status'])
+            self._start_next_tasks(parent_task=task)
+
     def start_task(
         self,
         task: Task,
@@ -642,16 +672,41 @@ def start_task(
                 self._start_prev_tasks(task)
             else:
                 self._start_next_tasks(parent_task=task)
-        else:  # noqa: PLR5501
-            if is_returned:
-                self.continue_workflow(task=task, is_returned=is_returned)
+            return
+        if task.skip_for_starter and not self.workflow.is_external:
+            starter = self.workflow.workflow_starter
+            starter_perf = (
+                TaskPerformer.objects
+                .by_task(task.id)
+                .exclude_directly_deleted()
+                .by_user_or_group(starter.id)
+                .first()
+            )
+            if starter_perf:
+                if not task.require_completion_by_all:
+                    self._skip_task_for_starter(task, is_returned)
+                    return
+
+                has_other_performers = (
+                    TaskPerformer.objects
+                    .by_task(task.id)
+                    .exclude_directly_deleted()
+                    .exclude(pk=starter_perf.pk)
+                    .exists()
+                )
+                if not has_other_performers:
+                    self._skip_task_for_starter(task, is_returned)
+                    return
+
+        if is_returned:
+            self.continue_workflow(task=task, is_returned=is_returned)
+        else:
+            delay = task.get_active_delay()
+            if delay:
+                self.delay_task(task=task, delay=delay)
+                self._start_next_tasks()
             else:
-                delay = task.get_active_delay()
-                if delay:
-                    self.delay_task(task=task, delay=delay)
-                    self._start_next_tasks()
-                else:
-                    self.continue_workflow(task=task, is_returned=is_returned)
+                self.continue_workflow(task=task, is_returned=is_returned)
 
     def complete_task(self, task: Task, by_user: bool = False):
 

backend/src/processes/tests/test_services/test_tasks/test_task_service.py

@@ -92,11 +92,46 @@ def test_create_instance__all_fields__ok(mocker):
     assert task.description_template == description
     assert task.number == 1
     assert task.require_completion_by_all is True
+    assert task.skip_for_starter is False
     assert task.is_urgent is True
     assert task.checklists_total == 2
     clear_mock.assert_called_once_with(description)
 
 
+def test_create_instance__skip_flag_true__ok(mocker):
+
+    # arrange
+    user = create_test_user()
+    template = create_test_template(user=user, tasks_count=1)
+    template_task = template.tasks.get(number=1)
+    template_task.skip_for_starter = True
+    template_task.save(
+        update_fields=['skip_for_starter'],
+    )
+    workflow = create_test_workflow(user, template=template)
+    workflow.tasks.delete()
+    clear_description = 'clear'
+    mocker.patch(
+        'src.services.markdown.MarkdownService.clear',
+        return_value=clear_description,
+    )
+    service = TaskService(
+        user=user,
+        instance=None,
+    )
+
+    # act
+    service._create_instance(
+        instance_template=template_task,
+        workflow=workflow,
+    )
+
+    # assert
+    task = service.instance
+    assert task.skip_for_starter is True
+    assert task.require_completion_by_all is False
+
+
 def test_get_task_due_date__raw_due_date_not_exist__return_none():
 
     # arrange

backend/src/processes/tests/test_services/test_tasks/test_task_version_service.py

@@ -101,10 +101,53 @@ def test_create_or_update_instance__update_all_fields__ok(mocker):
     assert task.description_template == description
     assert task.number == 1
     assert task.require_completion_by_all is True
+    assert task.skip_for_starter is False
     assert task.is_urgent is True
     clear_mock.assert_called_once_with(description)
 
 
+def test_create_or_update__skip_flag_true__ok(mocker):
+
+    # arrange
+    user = create_test_owner()
+    template = create_test_template(user=user, tasks_count=1)
+    workflow = create_test_workflow(
+        user=user,
+        template=template,
+        is_urgent=True,
+    )
+    clear_description = 'clear'
+    mocker.patch(
+        'src.services.markdown.MarkdownService.clear',
+        return_value=clear_description,
+    )
+    template_task = template.tasks.get(number=1)
+    template_task.skip_for_starter = True
+    template_task.save(
+        update_fields=['skip_for_starter'],
+    )
+    task_data = TaskSchemaV1(instance=template_task).data
+
+    task = workflow.tasks.get(number=1)
+    service = TaskUpdateVersionService(
+        user=user,
+        instance=task,
+        auth_type=AuthTokenType.USER,
+        is_superuser=False,
+    )
+
+    # act
+    task = service._create_or_update_instance(
+        data=task_data,
+        workflow=workflow,
+        fields_values={},
+    )
+
+    # assert
+    assert task.skip_for_starter is True
+    assert task.require_completion_by_all is False
+
+
 def test_create_or_update_instance__remove_revert_task__ok():
 
     # arrange