Skip to content

Commit c68c6d5

Browse files
committed
Delete outdated comments
1 parent 29e9bcd commit c68c6d5

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

probdiffeq/ivpsolve.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,6 @@ def body_fn(s, dt):
296296
_t, (posterior, output_scale) = solver.extract(result_state)
297297

298298
# I think the user expects marginals, so we compute them here
299-
# posterior_t0, *_ = initial_condition
300299
posterior_t0 = initial_condition.posterior
301300
_tmp = _userfriendly_output(posterior=posterior, posterior_t0=posterior_t0, ssm=ssm)
302301
marginals, posterior = _tmp

probdiffeq/ivpsolvers.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,6 @@
1616
R = TypeVar("R")
1717

1818

19-
# TODO (internal implementations):
20-
# - No more begin() and complete() steps. Replace with something less ambiguous.
21-
# - No more extract(). Replace with
22-
# iterating on solution (the result of extract) + solver_state (everything else)
23-
# - Make interpolation decision (before, at, after t1) on the lowest level possible
24-
25-
2619
class _MarkovProcess(containers.NamedTuple):
2720
tcoeffs: Any
2821
output_scale: Any
@@ -1046,7 +1039,7 @@ def init(s0: _AdaState) -> _RejectionState:
10461039
def _inf_like(tree):
10471040
return tree_util.tree_map(lambda x: np.inf() * np.ones_like(x), tree)
10481041

1049-
smaller_than_1 = 1.0 / 1.1 # the cond() must return True
1042+
smaller_than_1 = 0.9 # the cond() must return True
10501043
return _RejectionState(
10511044
error_norm_proposed=smaller_than_1,
10521045
dt=s0.dt,
@@ -1210,7 +1203,7 @@ def init(_dt: float, /) -> float:
12101203
return 1.0
12111204

12121205
def apply(dt: float, error_power_prev: float, /, *, error_power):
1213-
# error_power = error_norm ** (-1.0 / error_contraction_rate)
1206+
# Equivalent: error_power = error_norm ** (-1.0 / error_contraction_rate)
12141207
a1 = error_power**power_integral_unscaled
12151208
a2 = (error_power / error_power_prev) ** power_proportional_unscaled
12161209
scale_factor_unclipped = safety * a1 * a2

0 commit comments

Comments
 (0)