-
Notifications
You must be signed in to change notification settings - Fork 175
psl examples #52
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation
Type
Fields
Give feedbackNo fields configured for issues without a type.
@aarontuor @aaron-tuor @madelynshapiro
The current toml file does not include all the dependencies necessary to run psl examples in:
https://github.com/pnnl/neuromancer/tree/master/examples/psl
there are broken notebook examples:
all psl examples lack proper documentation to guide the user through the functionality of the library
There are also broken psl examples in the test folder:
https://github.com/pnnl/neuromancer/blob/master/tests/psl/coupled_sys_test.ipynb
Missing dependencies:
Failing tests in: psl\test_directory.py
assert os.path.normcase(nm_path1)==os.path.normcase(nm_path2), 'installed neuromancer root directory not the same as test root directory' AssertionError: installed neuromancer root directory not the same as test root directoryI am of strong opinion not to include all these psl_gym dependencies in our base environment.
the pygame visualisation should be a separate project independent of Neuromancer for now