Skip to content

psl examples #52

@drgona

Description

@drgona

@aarontuor @aaron-tuor @madelynshapiro

The current toml file does not include all the dependencies necessary to run psl examples in:
https://github.com/pnnl/neuromancer/tree/master/examples/psl

there are broken notebook examples:

all psl examples lack proper documentation to guide the user through the functionality of the library

There are also broken psl examples in the test folder:
https://github.com/pnnl/neuromancer/blob/master/tests/psl/coupled_sys_test.ipynb

Missing dependencies:

  • pygame-menu
  • stable_baselines3

Failing tests in: psl\test_directory.py
assert os.path.normcase(nm_path1)==os.path.normcase(nm_path2), 'installed neuromancer root directory not the same as test root directory' AssertionError: installed neuromancer root directory not the same as test root directory

I am of strong opinion not to include all these psl_gym dependencies in our base environment.
the pygame visualisation should be a separate project independent of Neuromancer for now

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdocumentationImprovements or additions to documentation

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions