Set default connection type aligned to the target binary type

jansenbe · jansenbe · commit 1c0c66b50915 · 2019-04-03T17:33:17.000+02:00
diff --git a/Commands/Base/SPOnlineConnectionHelper.cs b/Commands/Base/SPOnlineConnectionHelper.cs
@@ -563,11 +563,16 @@ internal static SPOnlineConnection InstantiateSPOnlineConnection(Uri url, PSCred
                     context.Credentials = new NetworkCredential(credentials.UserName, credentials.Password);
                 }
             }
+#if SP2013 || SP2016 || SP2019
             var connectionType = ConnectionType.OnPrem;
+#else
+            var connectionType = ConnectionType.O365;
+#endif
             if (url.Host.ToUpperInvariant().EndsWith("SHAREPOINT.COM"))
             {
                 connectionType = ConnectionType.O365;
             }
+
             if (skipAdminCheck == false)
             {
                 if (IsTenantAdminSite(context))

Original file line number	Diff line number	Diff line change
`@@ -563,11 +563,16 @@ internal static SPOnlineConnection InstantiateSPOnlineConnection(Uri url, PSCred`
`563`	`563`	`context.Credentials = new NetworkCredential(credentials.UserName, credentials.Password);`
`564`	`564`	`}`
`565`	`565`	`}`
	`566`	`+#if SP2013 \|\| SP2016 \|\| SP2019`
`566`	`567`	`var connectionType = ConnectionType.OnPrem;`
	`568`	`+#else`
	`569`	`+ var connectionType = ConnectionType.O365;`
	`570`	`+#endif`
`567`	`571`	`if (url.Host.ToUpperInvariant().EndsWith("SHAREPOINT.COM"))`
`568`	`572`	`{`
`569`	`573`	`connectionType = ConnectionType.O365;`
`570`	`574`	`}`
	`575`	`+`
`571`	`576`	`if (skipAdminCheck == false)`
`572`	`577`	`{`
`573`	`578`	`if (IsTenantAdminSite(context))`