Skip to content

Commit 850ceba

Browse files
milanholemanswaldekmastykarz
authored andcommitted
Updates node version to node20
1 parent efc3b73 commit 850ceba

File tree

7 files changed

+224
-228
lines changed

7 files changed

+224
-228
lines changed

.github/workflows/check_pr.yml

+12-12
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,20 @@ jobs:
99
strategy:
1010
matrix:
1111
os: [macos-latest, windows-latest, ubuntu-latest]
12-
node: [18]
12+
node: [20]
1313

1414
steps:
15-
- uses: actions/checkout@v3
15+
- uses: actions/checkout@v4
1616

1717
- name: Use Node.js ${{ matrix.node }}
18-
uses: actions/setup-node@v3
18+
uses: actions/setup-node@v4
1919
with:
2020
node-version: ${{ matrix.node }}
2121
registry-url: "https://registry.npmjs.org"
2222

2323
- name: Cache node modules
2424
id: cache
25-
uses: actions/cache@v3
25+
uses: actions/cache@v4
2626
with:
2727
path: |
2828
**/node_modules
@@ -44,7 +44,7 @@ jobs:
4444
run: 7z a -ttar -xr!node_modules -r build.tar .
4545

4646
- name: Upload build artifact
47-
uses: actions/upload-artifact@v3
47+
uses: actions/upload-artifact@v4
4848
with:
4949
name: build-${{ matrix.os }}-${{ matrix.node }}
5050
path: build.tar
@@ -56,19 +56,19 @@ jobs:
5656
strategy:
5757
matrix:
5858
os: [macos-latest, windows-latest, ubuntu-latest]
59-
nodeRun: [18]
60-
nodeBuild: [18]
59+
nodeRun: [20]
60+
nodeBuild: [20]
6161

6262
steps:
6363
- name: Configure pagefile
6464
if: matrix.os == 'windows-latest'
65-
uses: al-cheb/configure-pagefile-action@v1.3
65+
uses: al-cheb/configure-pagefile-action@v1.4
6666
with:
6767
minimum-size: 16GB
6868
maximum-size: 16GB
6969
disk-root: "C:"
7070

71-
- uses: actions/download-artifact@v3
71+
- uses: actions/download-artifact@v4
7272
with:
7373
name: build-${{ matrix.os }}-${{ matrix.nodeBuild }}
7474

@@ -81,14 +81,14 @@ jobs:
8181
run: 7z x build.tar && del build.tar
8282

8383
- name: Use Node.js ${{ matrix.nodeRun }}
84-
uses: actions/setup-node@v3
84+
uses: actions/setup-node@v4
8585
with:
8686
node-version: ${{ matrix.nodeRun }}
8787
registry-url: "https://registry.npmjs.org"
8888

8989
- name: Cache node modules
9090
id: cache
91-
uses: actions/cache@v3
91+
uses: actions/cache@v4
9292
with:
9393
path: |
9494
**/node_modules
@@ -104,7 +104,7 @@ jobs:
104104
- name: Test with coverage
105105
run: npm run test:cov
106106

107-
- uses: actions/upload-artifact@v3
107+
- uses: actions/upload-artifact@v4
108108
with:
109109
name: coverage-${{ matrix.os }}-${{ matrix.nodeRun }}
110110
path: coverage.tar

.github/workflows/test.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,20 @@ jobs:
66

77
strategy:
88
matrix:
9-
node-version: [18.x]
9+
node-version: [20.x]
1010

1111
name: CLI Deploy Job
1212

1313
steps:
14-
- name: Login to tenant
15-
uses: pnp/action-cli-login@v2
14+
- name: Log in to tenant
15+
uses: pnp/action-cli-login@v3
1616
id: login
1717
with:
1818
ADMIN_USERNAME: ${{ secrets.ADMIN_USERNAME }}
1919
ADMIN_PASSWORD: ${{ secrets.ADMIN_PASSWORD }}
2020

2121
- name: Checkout
22-
uses: actions/checkout@v3
22+
uses: actions/checkout@v4
2323

2424
- name: CLI for Microsoft 365 Deploy
2525
uses: ./

.github/workflows/test_site.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,20 @@ jobs:
66

77
strategy:
88
matrix:
9-
node-version: [18.x]
9+
node-version: [20.x]
1010

1111
name: CLI Deploy Job
1212

1313
steps:
14-
- name: Login to tenant
15-
uses: pnp/action-cli-login@v2
14+
- name: Log in to tenant
15+
uses: pnp/action-cli-login@v3
1616
id: login
1717
with:
1818
ADMIN_USERNAME: ${{ secrets.ADMIN_USERNAME }}
1919
ADMIN_PASSWORD: ${{ secrets.ADMIN_PASSWORD }}
2020

2121
- name: Checkout
22-
uses: actions/checkout@v3
22+
uses: actions/checkout@v4
2323

2424
- name: CLI for Microsoft 365 Deploy
2525
uses: ./

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ v1.0.0 | v2.5.0
4141
- `APP_ID` : The id of the app that gets deployed
4242

4343
### Example workflow - CLI for Microsoft 365 Deploy
44-
On every `push` build the code, then login to Office 365 and then start deploying.
44+
On every `push` build the code, then log in to Office 365 and then start deploying.
4545

4646
```yaml
4747
name: SPFx CICD with CLI for Microsoft 365
@@ -69,7 +69,7 @@ jobs:
6969

7070
# CLI for Microsoft 365 login action
7171
- name: Login to tenant
72-
uses: pnp/action-cli-login@v2
72+
uses: pnp/action-cli-login@v3
7373
with:
7474
ADMIN_USERNAME: ${{ secrets.ADMIN_USERNAME }}
7575
ADMIN_PASSWORD: ${{ secrets.ADMIN_PASSWORD }}
@@ -80,7 +80,7 @@ jobs:
8080
# Option 1 - Deploy app at tenant level
8181
- name: Option 1 - Deploy app to tenant
8282
id: climicrosoft365deploy # optional - use if output needs to be used
83-
uses: pnp/action-cli-deploy@v4
83+
uses: pnp/action-cli-deploy@v5
8484
with:
8585
APP_FILE_PATH: sharepoint/solution/spfx-cli-microsoft365-action.sppkg
8686
SKIP_FEATURE_DEPLOYMENT: true
@@ -89,7 +89,7 @@ jobs:
8989

9090
# Option 2 - Deploy app to a site collection
9191
- name: Option 2 - Deploy app to a site collection
92-
uses: pnp/action-cli-deploy@v4
92+
uses: pnp/action-cli-deploy@v5
9393
with:
9494
APP_FILE_PATH: sharepoint/solution/spfx-cli-microsoft365-action.sppkg
9595
SCOPE: sitecollection

action.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ inputs:
55
description: Relative path of the app in your repo
66
required: true
77
SCOPE:
8-
description: 'Scope of the app catalog: tenant or sitecollection. Default is tenant'
8+
description: 'Scope of the app catalog: tenant or site collection. Default is tenant'
99
required: false
1010
default: tenant
1111
SITE_COLLECTION_URL:
12-
description: The URL of the site collection where the solution package will be added. Required if scope is set to sitecollection
12+
description: The URL of the site collection where the solution package will be added. Required if scope is set to site collection
1313
required: false
1414
SKIP_FEATURE_DEPLOYMENT:
1515
description: True or false. If the app supports tenant-wide deployment, deploy it to the whole tenant. Default is false
@@ -23,7 +23,7 @@ outputs:
2323
APP_ID:
2424
description: The Id of the app that gets deployed
2525
runs:
26-
using: node16
26+
using: node20
2727
main: dist/index.js
2828
branding:
2929
icon: download

0 commit comments

Comments
 (0)