Made force destroy option configurable in tfvars and documented

Author: jackiryan

README.md

@@ -115,6 +115,8 @@ This module uses the following input variables:
 | app_name                             | string       |                                                                                                                                  | "bignbit"                                                           |
 | default_tags                         | map(string)  |                                                                                                                                  | {}                                                                  |
 | lambda_container_image_uri           | string       |                                                                                                                                  | ""                                                                  |
+| force_delete_ecr                     | bool         | Force delete the ECR repository and all its images on destroy. Set to true when migrating resource names to avoid manual cleanup. | false                                                               |
+| force_destroy_staging_bucket         | bool         | Force destroy the staging S3 bucket and all its contents on destroy. Set to true when migrating resource names to avoid manual cleanup. | false                                                          |
 | harmony_job_status_interval_seconds  | number       | Interval in seconds for checking Harmony job status                                                                              | 20                                                                  |
 | harmony_job_status_max_attempts      | number       | Maximum number of attempts to check Harmony job status                                                                           | 15                                                                  |
 | harmony_job_status_backoff_rate      | number       | Backoff rate for Harmony job status checks                                                                                       | 1.0                                                                 |

examples/cumulus-tf/tfvars/sit.tfvars

@@ -6,3 +6,6 @@ prefix = "podaac-sit-svc"
 gibs_region="mocked"
 gibs_queue_name="mocked"
 gibs_account_id="mocked"
+
+force_delete_ecr             = false
+force_destroy_staging_bucket = false

terraform/lambda_functions.tf

@@ -22,7 +22,7 @@ locals {
 
 resource aws_ecr_repository "lambda-image-repo" {
   name         = local.ecr_image_name
-  force_delete = true
+  force_delete = var.force_delete_ecr
 }
 
 

terraform/s3.tf

@@ -7,7 +7,7 @@ locals {
 resource "aws_s3_bucket" "bignbit_staging_bucket" {
   count         = local.create_bucket ? 1 : 0
   bucket        = "${local.aws_resources_name}-staging"
-  force_destroy = true
+  force_destroy = var.force_destroy_staging_bucket
 
   lifecycle {
     ignore_changes = [

terraform/variables.tf

@@ -112,6 +112,18 @@ variable "lambda_container_image_uri" {
   default = ""
 }
 
+variable "force_delete_ecr" {
+  type        = bool
+  description = "Force delete the ECR repository and all its images on destroy. Set to true when migrating resource names to avoid manual cleanup."
+  default     = false
+}
+
+variable "force_destroy_staging_bucket" {
+  type        = bool
+  description = "Force destroy the staging S3 bucket and all its contents on destroy. Set to true when migrating resource names to avoid manual cleanup."
+  default     = false
+}
+
 variable "harmony_job_status_interval_seconds" {
     type = number
     description = "Interval in seconds for checking Harmony job status"