test/e2e: add volume plugin refresh regression tests

Signed-off-by: Yoonseo Han <yooncer00@gmail.com>

Author: yoonseo-han

test/e2e/volume_plugin_test.go

@@ -301,4 +301,133 @@ Removed:
 		Expect(volInspect2).Should(ExitCleanly())
 		Expect(volInspect2.OutputToString()).To(ContainSubstring("3"))
 	})
+
+	It("unrelated command after refresh does not log plugin errors for plugin volumes", func() {
+		podmanTest.AddImageToRWStore(volumeTest)
+
+		pluginStatePath := filepath.Join(podmanTest.TempDir, "volumes")
+		err := os.Mkdir(pluginStatePath, 0o755)
+		Expect(err).ToNot(HaveOccurred())
+
+		pluginName := "testvol7"
+		ctrName := "pluginCtrRefresh"
+		plugin := podmanTest.Podman([]string{
+			"run", "--name", ctrName, "--security-opt", "label=disable",
+			"-v", "/run/docker/plugins:/run/docker/plugins",
+			"-v", fmt.Sprintf("%v:%v", pluginStatePath, pluginStatePath),
+			"-d", volumeTest, "--sock-name", pluginName, "--path", pluginStatePath,
+		})
+		plugin.WaitWithDefaultTimeout()
+		Expect(plugin).Should(ExitCleanly())
+
+		err = WaitForFile(fmt.Sprintf("/run/docker/plugins/%s.sock", pluginName))
+		Expect(err).ToNot(HaveOccurred())
+
+		vol1 := "refreshVol1-" + stringid.GenerateRandomID()
+		vol2 := "refreshVol2-" + stringid.GenerateRandomID()
+		create1 := podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, vol1})
+		create1.WaitWithDefaultTimeout()
+		Expect(create1).Should(ExitCleanly())
+		create2 := podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, vol2})
+		create2.WaitWithDefaultTimeout()
+		Expect(create2).Should(ExitCleanly())
+
+		// Create the libpod alive file (runtime already initialized).
+		init := podmanTest.Podman([]string{"volume", "ls", "-q"})
+		init.WaitWithDefaultTimeout()
+		Expect(init).Should(ExitCleanly())
+
+		podmanTest.StopContainer(ctrName)
+
+		alivePath := filepath.Join(podmanTest.TmpDir, "alive")
+		err = os.Remove(alivePath)
+		Expect(err).ToNot(HaveOccurred())
+
+		netName := "refresh-net-" + stringid.GenerateRandomID()
+		session := podmanTest.Podman([]string{"--log-level=error", "network", "create", netName})
+		session.WaitWithDefaultTimeout()
+		Expect(session.ExitCode()).To(Equal(0))
+		Expect(session.ErrorToString()).NotTo(ContainSubstring("some functionality may not be available"))
+		Expect(session.ErrorToString()).NotTo(ContainSubstring("uses volume plugin"))
+
+		cleanup := podmanTest.Podman([]string{"network", "rm", netName})
+		cleanup.WaitWithDefaultTimeout()
+		Expect(cleanup).Should(ExitCleanly())
+	})
+
+	It("volume inspect with stopped plugin errors without finalize spam", func() {
+		podmanTest.AddImageToRWStore(volumeTest)
+
+		pluginStatePath := filepath.Join(podmanTest.TempDir, "volumes")
+		err := os.Mkdir(pluginStatePath, 0o755)
+		Expect(err).ToNot(HaveOccurred())
+
+		pluginName := "testvol8"
+		ctrName := "pluginCtrInspect"
+		plugin := podmanTest.Podman([]string{
+			"run", "--name", ctrName, "--security-opt", "label=disable",
+			"-v", "/run/docker/plugins:/run/docker/plugins",
+			"-v", fmt.Sprintf("%v:%v", pluginStatePath, pluginStatePath),
+			"-d", volumeTest, "--sock-name", pluginName, "--path", pluginStatePath,
+		})
+		plugin.WaitWithDefaultTimeout()
+		Expect(plugin).Should(ExitCleanly())
+
+		err = WaitForFile(fmt.Sprintf("/run/docker/plugins/%s.sock", pluginName))
+		Expect(err).ToNot(HaveOccurred())
+
+		volName := "inspectVol-" + stringid.GenerateRandomID()
+		create := podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, volName})
+		create.WaitWithDefaultTimeout()
+		Expect(create).Should(ExitCleanly())
+
+		init := podmanTest.Podman([]string{"volume", "ls", "-q"})
+		init.WaitWithDefaultTimeout()
+		Expect(init).Should(ExitCleanly())
+
+		podmanTest.StopContainer(ctrName)
+
+		inspect := podmanTest.Podman([]string{"volume", "inspect", volName})
+		inspect.WaitWithDefaultTimeout()
+		Expect(inspect).To(ExitWithErrorRegex(125, "cannot inspect"))
+		Expect(inspect.ErrorToString()).NotTo(ContainSubstring("some functionality may not be available"))
+	})
+
+	It("volume ls with stopped plugin fails on inspect without finalize spam", func() {
+		podmanTest.AddImageToRWStore(volumeTest)
+
+		pluginStatePath := filepath.Join(podmanTest.TempDir, "volumes")
+		err := os.Mkdir(pluginStatePath, 0o755)
+		Expect(err).ToNot(HaveOccurred())
+
+		pluginName := "testvol9"
+		ctrName := "pluginCtrLs"
+		plugin := podmanTest.Podman([]string{
+			"run", "--name", ctrName, "--security-opt", "label=disable",
+			"-v", "/run/docker/plugins:/run/docker/plugins",
+			"-v", fmt.Sprintf("%v:%v", pluginStatePath, pluginStatePath),
+			"-d", volumeTest, "--sock-name", pluginName, "--path", pluginStatePath,
+		})
+		plugin.WaitWithDefaultTimeout()
+		Expect(plugin).Should(ExitCleanly())
+
+		err = WaitForFile(fmt.Sprintf("/run/docker/plugins/%s.sock", pluginName))
+		Expect(err).ToNot(HaveOccurred())
+
+		volName := "lsVol-" + stringid.GenerateRandomID()
+		create := podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, volName})
+		create.WaitWithDefaultTimeout()
+		Expect(create).Should(ExitCleanly())
+
+		init := podmanTest.Podman([]string{"volume", "ls", "-q"})
+		init.WaitWithDefaultTimeout()
+		Expect(init).Should(ExitCleanly())
+
+		podmanTest.StopContainer(ctrName)
+
+		ls := podmanTest.Podman([]string{"--log-level=error", "volume", "ls", "-q"})
+		ls.WaitWithDefaultTimeout()
+		Expect(ls).To(ExitWithErrorRegex(125, "cannot inspect"))
+		Expect(ls.ErrorToString()).NotTo(ContainSubstring("some functionality may not be available"))
+	})
 })