image scp: preserve usernames containing an "@"

Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>

Author: ROKUMATE

pkg/domain/utils/scp.go

@@ -361,7 +361,10 @@ func ParseImageSCPArg(arg string) (*entities.ScpTransferImageOptions, []string,
 
 	switch {
 	case strings.Contains(arg, "@localhost::"): // image transfer between users
-		location.User, _, _ = strings.Cut(arg, "@")
+		// Split on "@localhost::" rather than the first "@" so usernames
+		// that themselves contain an "@" (e.g. Active Directory "user@domain")
+		// are preserved. See https://github.com/containers/podman/issues/27655
+		location.User, _, _ = strings.Cut(arg, "@localhost::")
 		location, err = ValidateImagePortion(location, arg)
 		if err != nil {
 			return nil, nil, err

pkg/domain/utils/scp_test.go

@@ -72,3 +72,29 @@ func TestValidateSCPArgs(t *testing.T) {
 		})
 	}
 }
+
+func TestParseImageSCPArg(t *testing.T) {
+	tests := []struct {
+		name     string
+		arg      string
+		wantUser string
+	}{
+		{
+			name:     "user without domain",
+			arg:      "user@localhost::alpine",
+			wantUser: "user",
+		},
+		{
+			name:     "username containing an @ (e.g. Active Directory)",
+			arg:      "user@domain@localhost::example.com/foo/bar:latest",
+			wantUser: "user@domain",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			location, _, err := ParseImageSCPArg(tt.arg)
+			assert.NoError(t, err)
+			assert.Equal(t, tt.wantUser, location.User)
+		})
+	}
+}