[DOCS] Update save and load docs to make dir loading support clearer#27961
Conversation
|
IMHO these changes do not make it clearer that save formats I feel that this change, with increased emphasis on saving to & load from directories makes it less clear to me personally and possibly to others. Please consider, in the main text, something like: |
|
LGTM. |
Sadly we support Podman remote on Linux hosts so your example isn't 100% correct sadly. I think the foot note is an improvement so I'm going to mark this PR as ready for review (even thought the wonderful Podman maintainers have already started reviewing this patch!) |
Honny1
left a comment
There was a problem hiding this comment.
I have only one small nit. Otherwise LGTM.
|
A friendly reminder that this PR had no activity for 30 days. |
|
@ninja-quokka PTAL |
|
@ninja-quokka Friendly ping - if you still have the time for this, a rebase would be necessary when you update it :) |
Podman remote clients don't support loading images from directories, this patch aims to make that clearer. This patch also aims to make it clearer that podman-load can load from URLs, directories and tar archives. Drop incorrect claims that --input is required on remote clients (stdin reading is supported) and avoid 'Linux only' wording since podman has native FreeBSD support. Fixes: podman-container-tools#27952 Signed-off-by: Lewis Denny <lewisdenny@me.com>
c0f0b06 to
11f8197
Compare
Thank you for the ping @ashley-cui ! Rebased and addressed feedback :) |
|
LGTM. Thanks! |
a61215a
into
podman-container-tools:main
Podman remote clients don't support loading images from directories, this patch aims to make that clearer.
This patch also aims to make it clearer that podman-load can load from URLs, directories and tar archives.
Fixes: #27952
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?