Skip to content

Commit cf2c069

Browse files
authored
chore: fix machine stream close (macadam upstream fix) (#1761)
### What does this PR do? See: redhat-developer/podman-desktop-rhel-ext#194 With the new changes coming to Podman Desktop for the fix, this also needs to be added too. Copying / pasting this into our `macadam-machine-stream.ts` to propagate the change. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> N/A ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Part of redhat-developer/podman-desktop-rhel-ext#81 ### How to test this PR? <!-- Please explain steps to reproduce --> N/A, have to wait for PD changes to propagate: PR's: - podman-desktop/podman-desktop#12982 - podman-desktop/podman-desktop#12981 Signed-off-by: Charlie Drage <charlie@charliedrage.com>
1 parent 30d794f commit cf2c069

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

packages/backend/src/macadam/macadam-machine-stream.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ export class ProviderConnectionShellAccessImpl implements ProviderConnectionShel
9898
.on('ready', () => {
9999
this.#client?.shell((err, stream) => {
100100
if (err) {
101-
console.error(err);
102101
this.onErrorEmit.fire({ error: err.message });
103102
return;
104103
}
@@ -132,7 +131,7 @@ export class ProviderConnectionShellAccessImpl implements ProviderConnectionShel
132131
onEnd: this.onEnd,
133132
write: this.write.bind(this),
134133
resize: this.resize.bind(this),
135-
close: this.close,
134+
close: this.close.bind(this),
136135
};
137136
}
138137
}

0 commit comments

Comments
 (0)