Skip to content

secrets.js: Windows Testing: UTF8 Failure #24

Open
@poing

Description

@poing

After converting tests from secrets.js, found tests_win in the GitHub workflow is failing UTF8 tests. It appears to be caused by Windows defaulting to CP-1252 encoding.

Since these are converted tests from the secrets.js package, going to apply a workaround to skip the failed tests.

Will focus efforts on dealing with the UTF8 if/when issue are encountered affect the Python implementation.

Workaround

Currently skipping the windows testing.

@pytest.mark.skipif(
    sys.platform.startswith("win"), reason="Windows defaults to CP-1252"
)
def test_with_UTF8():
    ...
@pytest.mark.skipif(
    sys.platform.startswith("win"), reason="Windows defaults to CP-1252"
)
def test_initialization():
    ...

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions