fix popup issue#63
Merged
Merged
Conversation
github-actions
Bot
added
Frontend
XploY04
requested changes
Aug 6, 2025
XploY04
left a comment
XploY04
left a comment
Collaborator
There was a problem hiding this comment.
Instead of opening it on the same tab, make a component which pops up on view resume
Collaborator
|
damn I was going to approve this |
github-actions
Bot
added
size-M
github-actions
Bot
added
size-M
github-actions
Bot
added
size-M
XploY04
approved these changes
Aug 20, 2025
vanishajr
pushed a commit
to vanishajr/pb-placements
that referenced
this pull request
Aug 21, 2025
* fix popup issue * component added * fix popup issue * component added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: What does this PR do?
Fix popup issue due to which resumes were not opening in safari.
Which issue(s) this PR fixes:
Changes Made
Describe the changes you've made in this PR:
Type of Change
How Has This Been Tested?
Describe the tests you ran:
Please describe the test cases and expected behavior:
1.
2.
Screenshots (if applicable)
Dependencies
Documentation
Comments:
Reviewer Notes