Query not updating

[StewartLynch]

1. When I present my FormView, I pass in an Item (item)

2. and a Property (currentPopertry) and the initializer, I convert them into State properties

3. I then FetchAll rooms to get my array of Room

4. Next, I use FetchOne to get the selectedRoom based on the item.propertyID matching the currentProperty.id

5. And finally, I initialize the **properties ** array, by using a (5) roomsQuery to determine all rooms where the room's propertyID is a match for the currentProperty.id

6. In my form, I have two pickers

   1. One for the array of properties with the selection bound to currentProperty
   2. The second is for an array of rooms which is the filtered array and the selection is bound to item.roomID

This works perfectly on initialization and the two pickers are correctly populated and selected binding are assigned.

7. I have two tasks that respond to changes in the pickers

   1. The first task allows me to change the roomID for the item and this works perfectly as it load the selectedRoom and updates the selection for item

   HERE IS WHERE IT FALLS APART

   2. The second task watches for changes on the bound currentProperty and so the picker is working correctly, however, when I try to reload rooms based on the new currentProperty. The roomsQuery never gets the updated currentProperty/

Here are printouts from the console.

Initial Presentation

0.000s PRAGMA query_only = 1
0.000s BEGIN DEFERRED TRANSACTION
0.000s SELECT "rooms"."id", "rooms"."name", "rooms"."location", "rooms"."propertyID" FROM "rooms" LIMIT 1
0.000s COMMIT TRANSACTION
0.000s PRAGMA query_only = 0
0.000s PRAGMA query_only = 1
0.000s BEGIN DEFERRED TRANSACTION
0.000s SELECT "rooms"."id", "rooms"."name", "rooms"."location", "rooms"."propertyID" FROM "rooms" WHERE ("rooms"."propertyID") = (1) ORDER BY "rooms"."name"
0.000s COMMIT TRANSACTION
0.000s PRAGMA query_only = 0
currentProperty.id: 1
0.000s PRAGMA query_only = 1
0.000s BEGIN DEFERRED TRANSACTION
0.000s SELECT "rooms"."id", "rooms"."name", "rooms"."location", "rooms"."propertyID" FROM "rooms" LIMIT 1
0.000s COMMIT TRANSACTION
0.000s PRAGMA query_only = 0
0.000s PRAGMA query_only = 1
0.000s BEGIN DEFERRED TRANSACTION
0.000s SELECT "rooms"."id", "rooms"."name", "rooms"."location", "rooms"."propertyID" FROM "rooms" WHERE ("rooms"."propertyID") = (1) ORDER BY "rooms"."name"
0.000s COMMIT TRANSACTION
0.000s PRAGMA query_only = 0

After changing property

When I change a property, you can see that the currentProperty.id changes, but the query is still using the previous one.

currentProperty.id: 2
0.000s PRAGMA query_only = 1
0.000s BEGIN DEFERRED TRANSACTION
0.000s SELECT "rooms"."id", "rooms"."name", "rooms"."location", "rooms"."propertyID" FROM "rooms" WHERE ("rooms"."propertyID") = (1) ORDER BY "rooms"."name"
0.000s COMMIT TRANSACTION
0.000s PRAGMA query_only = 0

I must be missing something

Here is the relevant ItemForm code with comment markers matching my points above.

struct ItemForm: View {
    @Environment(\.dismiss) var dismiss
    @State var item: Item.Draft // 1
    @State var currentProperty: Property // 2
    @FetchAll var rooms:[Room] //3
    @FetchOne var selectedRoom:Room.Draft // 4
    @FetchAll(Property.order(by: \.name)) var properties //4
    
    init(item: Item.Draft, currentProperty: Property) {
        self._item = State(initialValue: item) // 1
        self._currentProperty = State(initialValue: currentProperty)// 2
        self._selectedRoom = FetchOne(wrappedValue: Room.Draft(propertyID: currentProperty.id)) //4
        _rooms = FetchAll(roomsQuery) // 4
    }
    
    var roomsQuery: some SelectStatementOf<Room> { //5
        Room
            .where{$0.propertyID == currentProperty.id }
            .order(by: \.name)
    }
    
    @Dependency(\.defaultDatabase) var database
    var body: some View {
        Form {
          ....
          // 6.1
          Picker(selection: $currentProperty) {
                ForEach(properties) { property in
                    Text(property.name).tag(property)
                        .buttonStyle(.plain)
                }
            } label: {
                HStack {
                    Image(systemName: "house")
                        .font(.title)
                    
                    Text("Property")
                }
            }
          // 6.2
            Picker(selection: $item.roomID) {
              ForEach(rooms) { room in
                  Text(room.name)
                  .tag(room.id)
                  .buttonStyle(.plain)
              }
            } label: {
              HStack {
                Image(systemName: "door.left.hand.open")
                  .font(.title)
                  
                Text("Room")
              }
            }
        }
      // 7.1
      .task(id: item.roomID) {
            await withErrorReporting {
                try await $selectedRoom.load()
            }
        }
       // 7.2
        .task(id: currentProperty) {
            await withErrorReporting {
                print("currentProperty.id: \(currentProperty.id, default: "Unknown")")
                try await $rooms.load()
            }
        }
    }

[StewartLynch]

I figured it out. FetchOne is not the solution. I separated the pickers into a separarte subview and it works now as I need.

[stephencelis]

Glad you figured it out! Sorry for more radio silence. Holiday travel means less time in front of the computer the past couple weeks 😄