Merge branch 'main' into observable-object-conformance

Author: stephencelis

.github/workflows/ci.yml

@@ -132,21 +132,21 @@ jobs:
       - name: Update mtime for incremental builds
         uses: chetan/git-restore-mtime-action@v2
       - name: CaseStudies (SwiftUI)
-        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (SwiftUI)" xcodebuild
+        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (SwiftUI)" xcodebuild-raw
       - name: CaseStudies (UIKit)
-        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (UIKit)" xcodebuild
+        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (UIKit)" xcodebuild-raw
       - name: Search
-        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Search" xcodebuild
+        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Search" xcodebuild-raw
       - name: SyncUps
-        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SyncUps" xcodebuild
+        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SyncUps" xcodebuild-raw
       - name: SpeechRecognition
-        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SpeechRecognition" xcodebuild
+        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SpeechRecognition" xcodebuild-raw
       - name: TicTacToe
-        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="TicTacToe" xcodebuild
+        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="TicTacToe" xcodebuild-raw
       - name: Todos
-        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Todos" xcodebuild
+        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Todos" xcodebuild-raw
       - name: VoiceMemos
-        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="VoiceMemos" xcodebuild
+        run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="VoiceMemos" xcodebuild-raw
 
   check-macro-compatibility:
     name: Check Macro Compatibility

Sources/ComposableArchitecture/Core.swift

@@ -268,11 +268,9 @@ final class IfLetCore<Base: Core, State, Action>: Core {
   @inlinable
   @inline(__always)
   func send(_ action: Action) -> Task<Void, Never>? {
-    #if DEBUG
-      if BindingLocal.isActive && isInvalid {
-        return nil
-      }
-    #endif
+    if BindingLocal.isActive && isInvalid {
+      return nil
+    }
     return base.send(actionKeyPath(action))
   }
   @inlinable

Sources/ComposableArchitecture/UIKit/AlertStateUIKit.swift

@@ -28,18 +28,7 @@
     public convenience init<Action>(
       store: Store<AlertState<Action>, Action>
     ) {
-      let state = store.currentState
-      self.init(
-        title: String(state: state.title),
-        message: state.message.map { String(state: $0) },
-        preferredStyle: .alert
-      )
-      for button in state.buttons {
-        addAction(UIAlertAction(button, action: { _ = $0.map(store.send) }))
-      }
-      if state.buttons.isEmpty {
-        addAction(UIAlertAction(title: "OK", style: .cancel))
-      }
+      self.init(state: store.currentState) { _ = $0.map(store.send) }
     }
 
     /// Creates a `UIAlertController` from a ``Store`` focused on confirmation dialog state.
@@ -63,19 +52,7 @@
     public convenience init<Action>(
       store: Store<ConfirmationDialogState<Action>, Action>
     ) {
-      let state = store.currentState
-      self.init(
-        title: String(state: state.title),
-        message: state.message.map { String(state: $0) },
-        preferredStyle: .actionSheet
-      )
-      for button in state.buttons {
-        addAction(UIAlertAction(button, action: { _ = $0.map(store.send) }))
-      }
-      if state.buttons.isEmpty {
-        addAction(UIAlertAction(title: "OK", style: .cancel))
-      }
+      self.init(state: store.currentState) { _ = $0.map(store.send) }
     }
-
   }
 #endif

Tests/ComposableArchitectureTests/EffectRunTests.swift

@@ -166,6 +166,6 @@ final class EffectRunTests: BaseTCATestCase {
     await store.send(.tap).finish()
     await queue.advance(by: .seconds(1))
 
-    try await Task.sleep(nanoseconds: 100_000_000)
+    try await Task.sleep(nanoseconds: 1_000_000_000)
   }
 }