test

Author: nameexhaustion

crates/polars-expr/src/reduce/convert.rs

@@ -83,29 +83,29 @@ pub fn into_reduction(
             IRAggExpr::AggGroups(_) => todo!(),
         },
         AExpr::Len => {
-            if let Some(first_column) = schema.iter_names().next() {
-                let out: Box<dyn GroupedReduction> = Box::new(LenReduce::default());
-                let expr = expr_arena.add(AExpr::Column(first_column.as_str().into()));
+            // if let Some(first_column) = schema.iter_names().next() {
+            //     let out: Box<dyn GroupedReduction> = Box::new(LenReduce::default());
+            //     let expr = expr_arena.add(AExpr::Column(first_column.as_str().into()));
 
-                (out, expr)
-            } else {
-                // Support len aggregation on 0-width morsels.
-                // Notes:
-                // * We do this instead of projecting a scalar, because scalar literals don't
-                //   project to the height of the DataFrame (in the PhysicalExpr impl).
-                // * This approach is not sound for `update_groups()`, but currently that case is
-                //   not hit (it would need group-by -> len on empty morsels).
-                polars_ensure!(
-                    !is_aggregation_context,
-                    ComputeError:
-                    "not implemented: len() of groups with no columns"
-                );
+            //     (out, expr)
+            // } else {
+            //     // Support len aggregation on 0-width morsels.
+            //     // Notes:
+            //     // * We do this instead of projecting a scalar, because scalar literals don't
+            //     //   project to the height of the DataFrame (in the PhysicalExpr impl).
+            //     // * This approach is not sound for `update_groups()`, but currently that case is
+            //     //   not hit (it would need group-by -> len on empty morsels).
+            //     polars_ensure!(
+            //         !is_aggregation_context,
+            //         ComputeError:
+            //         "not implemented: len() of groups with no columns"
+            //     );
 
-                let out: Box<dyn GroupedReduction> = new_sum_reduction(DataType::IDX_DTYPE)?;
-                let expr = expr_arena.add(AExpr::Len);
+            let out: Box<dyn GroupedReduction> = new_sum_reduction(DataType::IDX_DTYPE)?;
+            let expr = expr_arena.add(AExpr::Len);
 
-                (out, expr)
-            }
+            (out, expr)
+            // }
         },
 
         AExpr::Function {