fixed bug leading to too much background flux in first row and column of detector

Author: jammartin

src/Detector.h

@@ -792,14 +792,20 @@ class CDetector
         {
             Vector3D pos = pp.getPosition();
 
-            uint x = uint((pos.X() + 0.5 * sidelength_x - map_shift_x) / sidelength_x * double(bins_x));
+	    double float_x = (pos.X() + 0.5 * sidelength_x - map_shift_x) / sidelength_x * double(bins_x);
+	    if (float_x < 0.) // integer casting leads to zeros from negative and positive side which results in too much flux in the lowest row
+		return; 
+	    uint x = uint(float_x);
 
-            if(x < 0 || x >= bins_x)
+            if(x >= bins_x) 
                 return;
 
-            uint y = uint((pos.Y() + 0.5 * sidelength_y - map_shift_y) / sidelength_y * double(bins_y));
+	    double float_y = (pos.Y() + 0.5 * sidelength_y - map_shift_y) / sidelength_y * double(bins_y);
+	    if (float_y < 0.) // integer casting leads to zeros from negative and positive side which results in too much flux in the lowest column
+		return;
+            uint y = uint(float_y);
 
-            if(y < 0 || y >= bins_y)
+            if(y >= bins_y)
                 return;
 
             matrixI[i_spectral].addValue(x, y, st.I());

src/Raytracing.h

@@ -1649,7 +1649,7 @@ class CRaytracingPolar : public CRaytracingBasic
             npix_total += npix_ph[i_r];
         }
 
-        npix_total++;
+        npix_total++; // last pixel is central grid cell 
 
         if(npix_total > MAX_RT_RAYS)
         {
@@ -1777,9 +1777,11 @@ class CRaytracingPolar : public CRaytracingBasic
         switch(processing_method)
         {
             case 0:
+		cout << "HINT: Using 'nearest' method to post process from polar to cartesian detector" << endl;
                 return postProcessingUsingNearest();
                 break;
             case 1:
+		cout << "HINT: Using 'interpolation' method to post process from polar to cartesian detector" << endl;
                 return postProcessingUsingInterpolation();
                 break;
             default:

src/Source.cpp

@@ -985,13 +985,9 @@ StokesVector CSourceBackground::getStokesVector(photon_package * pp)
 {
     double F, T, I, Q, U, V, pl;
     StokesVector res;
-    Vector3D pos = pp->getPosition();
 
     uint wID = pp->getDustWavelengthID();
 
-    uint x = uint((pos.X() + 0.5 * sidelength) / sidelength * double(bins));
-    uint y = uint((pos.Y() + 0.5 * sidelength) / sidelength * double(bins));
-
     if(constant)
     {
         if(c_f>=0)
@@ -1018,6 +1014,11 @@ StokesVector CSourceBackground::getStokesVector(photon_package * pp)
     }
     else
     {
+	Vector3D pos = pp->getPosition();
+
+	uint x = uint((pos.X() + 0.5 * sidelength) / sidelength * double(bins));
+	uint y = uint((pos.Y() + 0.5 * sidelength) / sidelength * double(bins));
+
         F = f(x, y);
         T = temp(x, y);
         Q = q(x, y);