refactor: fix golint

Author: evelynwei

pkg/cache/config_cache.go

@@ -40,11 +40,11 @@ func (csm *CachedConfigFileMap) Delete(key string) {
 func (csm *CachedConfigFileMap) Load(key string) (value *v1.ConfigMap, ok bool) {
 	v, ok := csm.sm.Load(key)
 	if v != nil {
-		value, ok2 := v.(*v1.ConfigMap)
+		result, ok2 := v.(*v1.ConfigMap)
 		if !ok2 {
 			ok = false
 		}
-		return value, ok
+		return result, ok
 	}
 	return value, ok
 }

pkg/cache/service_cache.go

@@ -40,11 +40,11 @@ func (csm *CachedServiceMap) Delete(key string) {
 func (csm *CachedServiceMap) Load(key string) (value *v1.Service, ok bool) {
 	v, ok := csm.sm.Load(key)
 	if v != nil {
-		value, ok2 := v.(*v1.Service)
+		result, ok2 := v.(*v1.Service)
 		if !ok2 {
 			ok = false
 		}
-		return value, ok
+		return result, ok
 	}
 	return value, ok
 }

pkg/controller/endpoint.go

@@ -192,7 +192,7 @@ func (p *PolarisController) processSyncInstance(service *v1.Service) (err error)
 		fmt.Sprintf("%s Current polaris instance is %v", serviceMsg, currentIPs),
 		fmt.Sprintf("%s addIns %v deleteIns %v updateIns %v", serviceMsg, addIns, deleteIns, updateIns),
 	}
-	log.SyncNamingScope().Infof(strings.Join(msg, "\n"))
+	log.SyncNamingScope().Info(strings.Join(msg, "\n"))
 
 	var addInsErr, deleteInsErr, updateInsErr error
 

pkg/polarisapi/config_api.go

@@ -46,7 +46,7 @@ func CreateConfigMap(configMap *v1.ConfigMap) (ConfigResponse, error) {
 	if err != nil {
 		return ConfigResponse{}, err
 	}
-	if err := releaseConfigMap(req); err != nil {
+	if err = releaseConfigMap(req); err != nil {
 		return ConfigResponse{}, err
 	}
 	return resp, err
@@ -62,7 +62,7 @@ func UpdateConfigMap(configMap *v1.ConfigMap) (ConfigResponse, error) {
 	if err != nil {
 		return ConfigResponse{}, err
 	}
-	if err := releaseConfigMap(req); err != nil {
+	if err = releaseConfigMap(req); err != nil {
 		return ConfigResponse{}, err
 	}
 	return resp, err

pkg/polarisapi/service_api.go

@@ -539,7 +539,7 @@ func CreateService(service *v1.Service) (CreateServicesResponse, error) {
 		}
 		if response.Code != ExistedResource {
 			log.SyncNamingScope().Errorf("Failed to create service %s %v", serviceMsg, response.Info)
-			return response, fmt.Errorf("create namespace failed: " + response.Info)
+			return response, fmt.Errorf("create namespace failed: %s", response.Info)
 		}
 	}
 
@@ -603,7 +603,7 @@ func CreateServiceAlias(service *v1.Service) (CreateServiceAliasResponse, error)
 		}
 		if response.Code != ExistedResource {
 			log.SyncNamingScope().Errorf("Failed to create service alias %s %v", serviceAliasMsg, response.Info)
-			return response, fmt.Errorf("create service alias failed: " + response.Info)
+			return response, fmt.Errorf("create service alias failed: %s", response.Info)
 		}
 	}
 
@@ -648,7 +648,7 @@ func UpdateService(service *v1.Service, request []Service) (int, PutServicesResp
 			return statusCode, PutServicesResponse{}, err
 		}
 		log.SyncNamingScope().Errorf("Failed to update result %s %v", serviceMsg, response.Info)
-		return statusCode, response, fmt.Errorf("Put service failed: " + response.Info)
+		return statusCode, response, fmt.Errorf("Put service failed: %s ", response.Info)
 	}
 
 	return statusCode, response, nil
@@ -697,7 +697,7 @@ func CreateNamespaces(namespace string) (CreateNamespacesResponse, error) {
 		if response.Responses == nil || len(response.Responses) == 0 ||
 			response.Responses[0].Code != ExistedResource {
 			log.SyncNamingScope().Errorf("Failed to create namespace %s ,error response: %v", namespace, response)
-			return response, fmt.Errorf("create namespace failed: " + response.Info)
+			return response, fmt.Errorf("create namespace failed: %s", response.Info)
 		}
 	}