Skip to content

Commit c0fd23f

Browse files
fix:fix multi register and discovery bug. (#268) (#269)
1 parent f60aa51 commit c0fd23f

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

polaris-common/polaris-config/src/main/java/com/tencent/polaris/factory/config/consumer/ConsumerConfigImpl.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public class ConsumerConfigImpl implements ConsumerConfig {
5757
private List<DiscoveryConfigImpl> discoveries;
5858

5959
@JsonIgnore
60-
private Map<String, DiscoveryConfigImpl> discoveryConfigMap = new ConcurrentHashMap<>();
60+
private final Map<String, DiscoveryConfigImpl> discoveryConfigMap = new ConcurrentHashMap<>();
6161

6262
@Override
6363
public LocalCacheConfigImpl getLocalCache() {
@@ -96,7 +96,7 @@ public List<DiscoveryConfigImpl> getDiscoveries() {
9696
return discoveries;
9797
}
9898

99-
public void setDiscoveries(List<DiscoveryConfigImpl> discoveries) {
99+
private void setDiscoveryConfigMap(List<DiscoveryConfigImpl> discoveries) {
100100
if (CollectionUtils.isNotEmpty(discoveries)) {
101101
for (DiscoveryConfigImpl discoveryConfig : discoveries) {
102102
if (discoveryConfigMap.containsKey(discoveryConfig.getServerConnectorId())) {
@@ -107,7 +107,6 @@ public void setDiscoveries(List<DiscoveryConfigImpl> discoveries) {
107107
}
108108
}
109109
}
110-
this.discoveries = discoveries;
111110
}
112111

113112
@Override
@@ -134,6 +133,7 @@ public void verify() {
134133
discoveryConfig.verify();
135134
}
136135
}
136+
setDiscoveryConfigMap(discoveries);
137137
}
138138

139139
@Override

polaris-common/polaris-config/src/main/java/com/tencent/polaris/factory/config/provider/ProviderConfigImpl.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public class ProviderConfigImpl implements ProviderConfig {
4747
private List<RegisterConfigImpl> registers;
4848

4949
@JsonIgnore
50-
private Map<String, RegisterConfigImpl> registerConfigMap = new ConcurrentHashMap<>();
50+
private final Map<String, RegisterConfigImpl> registerConfigMap = new ConcurrentHashMap<>();
5151

5252
@JsonProperty
5353
private long minRegisterInterval;
@@ -70,7 +70,7 @@ public List<RegisterConfigImpl> getRegisters() {
7070
return registers;
7171
}
7272

73-
public void setRegisters(List<RegisterConfigImpl> registers) {
73+
private void setRegisterConfigMap(List<RegisterConfigImpl> registers) {
7474
if (CollectionUtils.isNotEmpty(registers)) {
7575
for (RegisterConfigImpl registerConfig : registers) {
7676
if (registerConfigMap.containsKey(registerConfig.getServerConnectorId())) {
@@ -81,7 +81,6 @@ public void setRegisters(List<RegisterConfigImpl> registers) {
8181
}
8282
}
8383
}
84-
this.registers = registers;
8584
}
8685

8786
@Override
@@ -99,6 +98,7 @@ public void verify() {
9998
registerConfig.verify();
10099
}
101100
}
101+
setRegisterConfigMap(registers);
102102
}
103103

104104
@Override

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464

6565
<properties>
6666
<!-- Project revision -->
67-
<revision>1.10.1</revision>
67+
<revision>1.10.2</revision>
6868

6969
<timestamp>${maven.build.timestamp}</timestamp>
7070
<skip.maven.deploy>false</skip.maven.deploy>

0 commit comments

Comments
 (0)