Skip to content

Commit 48e8510

Browse files
committed
fix:服务列表支持服务可见性&修复服务可见性优先级判断
1 parent 722ebbf commit 48e8510

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

service/client_v1.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,9 @@ func (s *Server) GetServiceWithCache(ctx context.Context, req *apiservice.Servic
184184
revisions = append(revisions, visibleSvcs[i].Revision)
185185
}
186186
if rever, err := cachetypes.CompositeComputeRevision(revisions); err != nil {
187-
// 如果计算失败,直接返回一个新的revision
188-
revision = utils.NewUUID()
187+
log.Errorf("[Server][Discover] list services compute multi revision",
188+
zap.String("namespace", req.GetNamespace().GetValue()), zap.Error(err))
189+
return api.NewDiscoverInstanceResponse(apimodel.Code_ExecuteException, req)
189190
} else {
190191
revision = rever
191192
}

store/mysql/service.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,6 @@ func callFetchServiceRows(rows *sql.Rows, callback func(entry *model.Service) (b
10501050
}
10511051
defer rows.Close()
10521052

1053-
var ctime, mtime int64
10541053
var flag int
10551054
progress := 0
10561055
for rows.Next() {
@@ -1063,7 +1062,7 @@ func callFetchServiceRows(rows *sql.Rows, callback func(entry *model.Service) (b
10631062
var exportTo string
10641063
err := rows.Scan(
10651064
&item.ID, &item.Name, &item.Namespace, &item.Business, &item.Comment,
1066-
&item.Token, &item.Revision, &item.Owner, &flag, &ctime, &mtime, &item.Ports,
1065+
&item.Token, &item.Revision, &item.Owner, &flag, &item.Ctime, &item.Mtime, &item.Ports,
10671066
&item.Department, &item.CmdbMod1, &item.CmdbMod2, &item.CmdbMod3,
10681067
&item.Reference, &item.ReferFilter, &item.PlatformID, &exportTo)
10691068

@@ -1072,8 +1071,8 @@ func callFetchServiceRows(rows *sql.Rows, callback func(entry *model.Service) (b
10721071
return err
10731072
}
10741073

1075-
item.CreateTime = time.Unix(ctime, 0)
1076-
item.ModifyTime = time.Unix(mtime, 0)
1074+
item.CreateTime = time.Unix(item.Ctime, 0)
1075+
item.ModifyTime = time.Unix(item.Mtime, 0)
10771076
item.ExportTo = map[string]struct{}{}
10781077
_ = json.Unmarshal([]byte(exportTo), &item.ExportTo)
10791078
item.Valid = true

0 commit comments

Comments
 (0)