Support commons-io 2.7

[Dichotomia]

Released 28 May 2020: http://commons.apache.org/proper/commons-io/changes-report.html#a2.7

[uschindler]

Thanks for the hint! I will check it for changes by API difference.

For now I would recommend to use signatures of version 2.6.

Uwe

[Dichotomia]

I doesn't work with commons-io-unsafe-2.6

[uschindler]

Why should it not work? There is no requirement to use the latest signatures file. Please give more details!

[Dichotomia]

[ERROR] Failed to execute goal �[32mde.thetaphi:forbiddenapis:3.0:check�[m �[1m(check)�[m on project �[36mmac-bc360-custom�[m: �[1;31mParsing signatures failed: Method not found while parsing signature: org.apache.commons.io.output.ByteArrayOutputStream#toString()�[m -> �[1m[Help 1]�[m

[Dichotomia]

I think that the method toString() has been deleted in commons-io 2.7

[Dichotomia]

With the stack trace:
[ERROR] Failed to execute goal de.thetaphi:forbiddenapis:3.0:check (check) on project mac-bc360-custom: Parsing signatures failed: Method not found while parsing signature: org.apache.commons.io.output.ByteArrayOutputStream#toString() -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal de.thetaphi:forbiddenapis:3.0:check (check) on project mac-bc360-custom: Parsing signatures failed: Method not found while parsing signature: org.apache.commons.io.output.ByteArrayOutputStream#toString()
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.apache.maven.plugin.MojoExecutionException: Parsing signatures failed: Method not found while parsing signature: org.apache.commons.io.output.ByteArrayOutputStream#toString()
at de.thetaphi.forbiddenapis.maven.AbstractCheckMojo.execute (AbstractCheckMojo.java:432)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: de.thetaphi.forbiddenapis.ParseException: Method not found while parsing signature: org.apache.commons.io.output.ByteArrayOutputStream#toString()
at de.thetaphi.forbiddenapis.Signatures$UnresolvableReporting$1.parseFailed (Signatures.java:56)
at de.thetaphi.forbiddenapis.Signatures.addSignature (Signatures.java:202)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:302)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesFile (Signatures.java:284)
at de.thetaphi.forbiddenapis.Signatures.parseSignaturesStream (Signatures.java:268)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:264)
at de.thetaphi.forbiddenapis.Signatures.addBundledSignatures (Signatures.java:311)
at de.thetaphi.forbiddenapis.Checker.addBundledSignatures (Checker.java:317)
at de.thetaphi.forbiddenapis.maven.AbstractCheckMojo.execute (AbstractCheckMojo.java:393)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

[uschindler]

Hi @Dichotomia thanks, this looks like the issue. What confuses me: I did not find any mentions about this in the release notes of 2.7. Was this metjod deprecated, otherwise it looks like a backwards-incompatible change in commons-io, breaking user updating. Of course they should have never used that method, as it does not use correct charset.

I'd suggest as a workaround to disable that it fails un unresolvable signatures.

[Dichotomia]

Ok. I try to warn commons-io about it, because the version is marked as binary compatible.

Sorry, i didn't understand what the workaround is.

[uschindler]

To get past the error in forbiddenapis, you can switch off this flag (set it to false): https://jenkins.thetaphi.de/job/Forbidden-APIs/javadoc/check-mojo.html#failOnUnresolvableSignatures

[Dichotomia]

Ok thanks.

Issue in commons-io : https://issues.apache.org/jira/browse/IO-671

[uschindler]

I found the issue: There is no binary incompatibility, the problem is that the method was moved to an abstract superclass in forbiddenapis. It's no longer directly inside ByteArrayOutputStream().

To fix this, I need to release a new signatures file for 2.7 (as proposed here), but on the other hand think about ways how to handle that in signatures files. Currently all signatures must resolve directly, there's no virtual method resolving introduced.