Skip to content

**kwargs in reddwarf.implementations.polis.run_pipeline is not typed #86

@nicobao

Description

@nicobao

Here:

https://github.com/polis-community/red-dwarf/blob/main/reddwarf/implementations/polis.py#L14

This function is not properly statically typed.

Currently

from reddwarf.implementations.polis import run_pipeline

    dummy_var = ...
    run_pipeline(dummary_var) # the compiler will not say anything

But

from reddwarf.implementations.base import run_pipeline

    dummy_var = ...
    run_pipeline(dummary_var) # the compiler will throw an error as expected

Solution:

  • create a subtype for this **kwargs in the polis-specific implementation, (excluding reducer and clusterer params from the object)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions