Prevent arithmetic overflow panick when handling XCM (#328)

Author: Wizdave97

Cargo.lock

@@ -21,6 +21,7 @@ use std::sync::Arc;
 use anyhow::anyhow;
 use codec::{Decode, Encode};
 use cumulus_relay_chain_interface::RelayChainInterface;
+use sp_api::ApiExt;
 use sp_runtime::{
 	generic::{BlockId, Header},
 	traits::{BlakeTwo256, Block as BlockT},
@@ -51,6 +52,12 @@ impl ConsensusInherentProvider {
 		C::Api: IsmpParachainApi<B> + IsmpRuntimeApi<B, B::Hash>,
 		B: BlockT,
 	{
+		// Check if it has the parachain runtime api
+		if !client.runtime_api().has_api::<dyn IsmpParachainApi<B>>(parent)? {
+			log::trace!("IsmpParachainApi not implemented");
+			return Ok(ConsensusInherentProvider(None));
+		}
+
 		let para_ids = client.runtime_api().para_ids(parent)?;
 
 		log::trace!("ParaIds from runtime: {para_ids:?}");

modules/ismp/clients/parachain/inherent/src/lib.rs

@@ -182,7 +182,10 @@ where
 			let base_fee =
 				if who.dest_state_machine == StateMachine::Evm(1) { 20_000_000_000u128 } else { 0 };
 			let protocol_fees = protocol_percentage * u128::from(amount) + base_fee;
-			let remainder = amount - protocol_fees.into();
+			let remainder = u128::from(amount)
+				.checked_sub(protocol_fees.into())
+				.ok_or_else(|| XcmError::Overflow)?
+				.into();
 			// Mint protocol fees
 			T::Assets::mint_into(asset_id.clone(), &protocol_account, protocol_fees.into())
 				.map_err(|e| XcmError::FailedToTransactAsset(e.into()))?;

modules/ismp/pallets/asset-gateway/src/xcm_utilities.rs

@@ -1,6 +1,6 @@
 [package]
 name = "hyperbridge"
-version = "0.6.2"
+version = "0.6.3"
 authors = ["Polytope Labs <[email protected]>"]
 description = "The Hyperbridge coprocessor node"
 repository = "https://github.com/polytope-labs/hyperbridge"

parachain/node/Cargo.toml

@@ -233,7 +233,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
 	spec_name: create_runtime_str!("gargantua"),
 	impl_name: create_runtime_str!("gargantua"),
 	authoring_version: 1,
-	spec_version: 1150,
+	spec_version: 1160,
 	impl_version: 0,
 	apis: RUNTIME_API_VERSIONS,
 	transaction_version: 1,