remove converter

Author: polyzos

fluss-client/src/main/java/org/apache/fluss/client/utils/ConverterUtils.java

@@ -29,7 +29,6 @@
 import org.apache.fluss.types.LocalZonedTimestampType;
 import org.apache.fluss.types.RowType;
 import org.apache.fluss.types.TimestampType;
-import org.apache.fluss.utils.MapUtils;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -51,7 +50,6 @@
 import java.util.LinkedHashSet;
 import java.util.Map;
 import java.util.Set;
-import java.util.concurrent.ConcurrentHashMap;
 
 /**
  * Helper class for converting Java objects to Fluss's {@link InternalRow} format and vice versa.
@@ -81,10 +79,6 @@
 public class ConverterUtils<T> {
     private static final Logger LOG = LoggerFactory.getLogger(ConverterUtils.class);
 
-    /** Cache for converters to avoid repeated reflection operations. */
-    private static final ConcurrentHashMap<CacheKey, ConverterUtils<?>> CONVERTER_CACHE =
-            MapUtils.newConcurrentHashMap();
-
     /** Map of supported Java types for each DataTypeRoot. */
     private static final Map<DataTypeRoot, Set<Class<?>>> SUPPORTED_TYPES = new HashMap<>();
 
@@ -168,9 +162,7 @@ private ConverterUtils(Class<T> pojoClass, RowType rowType) {
      */
     @SuppressWarnings("unchecked")
     public static <T> ConverterUtils<T> getConverter(Class<T> pojoClass, RowType rowType) {
-        CacheKey key = new CacheKey(pojoClass, rowType);
-        return (ConverterUtils<T>)
-                CONVERTER_CACHE.computeIfAbsent(key, k -> new ConverterUtils<>(pojoClass, rowType));
+        return new ConverterUtils<>(pojoClass, rowType);
     }
 
     /** Creates field converters for converting from POJO to Row for each field in the schema. */
@@ -580,31 +572,4 @@ private static LinkedHashSet<Class<?>> orderedSet(Class<?>... javaTypes) {
         return linkedHashSet;
     }
 
-    /** Key for caching converters. */
-    private static class CacheKey {
-        private final Class<?> pojoClass;
-        private final RowType rowType;
-
-        public CacheKey(Class<?> pojoClass, RowType rowType) {
-            this.pojoClass = pojoClass;
-            this.rowType = rowType;
-        }
-
-        @Override
-        public boolean equals(Object o) {
-            if (this == o) {
-                return true;
-            }
-            if (o == null || getClass() != o.getClass()) {
-                return false;
-            }
-            CacheKey cacheKey = (CacheKey) o;
-            return pojoClass.equals(cacheKey.pojoClass) && rowType.equals(cacheKey.rowType);
-        }
-
-        @Override
-        public int hashCode() {
-            return 31 * pojoClass.hashCode() + rowType.hashCode();
-        }
-    }
 }

fluss-client/src/test/java/org/apache/fluss/client/utils/ConverterUtilsTest.java

@@ -176,7 +176,7 @@ public void testCaching() {
         ConverterUtils<TestPojo> converter2 =
                 ConverterUtils.getConverter(TestPojo.class, createTestPojoRowType());
 
-        assertThat(converter2).isSameAs(converter1);
+        assertThat(converter2).isNotSameAs(converter1);
     }
 
     @Test