Skip to content

Seems to be incompatible with mdx-deck 2.0 #53

Closed
@emirotin

Description

@emirotin

First, a peer dep of styled-components is required for it to work and it's not mentioned in the readme

Second, it fails with withDeck not being a function

Activity

emirotin

emirotin commented on Mar 19, 2019

@emirotin
Author

WRT the first one mdx-deck has switched to emotion and is now using emotion-theming.
For the 2nd the changes seem to be too major and I'm unfamiliar with the code base of both projects so I wasn't able to spot the proper change but there are withContext HOC and useDeck hook now exported from mdx-deck that are probably the way to go.

mbilokonsky

mbilokonsky commented on Mar 21, 2019

@mbilokonsky

Just hit this too, which is a bummer because this was going to be a perfect tool for the deck I'm building!

pomber

pomber commented on Mar 21, 2019

@pomber
Owner

I'm planning to do a big refactor (and add more features), but I'm currently busy with other things. So the ETA is end of April.

mbilokonsky

mbilokonsky commented on Mar 21, 2019

@mbilokonsky

awesome, thanks!

emirotin

emirotin commented on Mar 21, 2019

@emirotin
Author

@mbilokonsky use mdx-deck ^1.10.0 it works nice, the docs are here https://github.com/jxnblk/mdx-deck/tree/v1.10.2/docs

madrus

madrus commented on Apr 21, 2019

@madrus

1.10.0
Works with inline code but not with code snippets like code={require("!raw-loader!./my-snippet.js")}. code parameter expects a string and not an object (error message).

w1zd

w1zd commented on Apr 22, 2019

@w1zd

1.10.0
Works with inline code but not with code snippets like code={require("!raw-loader!./my-snippet.js")}. code parameter expects a string and not an object (error message).

Same issue as you.

christopherjbaker

christopherjbaker commented on Apr 24, 2019

@christopherjbaker

@madrus @finish8 use code={require("!raw-loader!./my-snippet.js").default} instead

madrus

madrus commented on Apr 26, 2019

@madrus

@madrus @finish8 use code={require("!raw-loader!./my-snippet.js").default} instead

Wow! It works indeed. Thanks!

w1zd

w1zd commented on Apr 29, 2019

@w1zd

@madrus @finish8 use code={require("!raw-loader!./my-snippet.js").default} instead

love you 😘

aleclarson

aleclarson commented on May 9, 2019

@aleclarson

#54 works for me

pomber

pomber commented on May 10, 2019

@pomber
Owner

I'm planning to do a big refactor (and add more features), but I'm currently busy with other things. So the ETA is end of April.

Update: Now I have time to work on releasing a new version, so expect an alpha of code surfer v2 soon.

2 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Seems to be incompatible with mdx-deck 2.0 · Issue #53 · pomber/code-surfer