nonsplitting mode now is default (only for windows)

Author: Евгений Блинов

suby/proxy_module.py

@@ -27,12 +27,15 @@ def __call__(
         stdout_callback: Callable[[str], Any] = stdout_with_flush,
         stderr_callback: Callable[[str], Any] = stderr_with_flush,
         timeout: Optional[Union[int, float]] = None,
-        split: bool = True,
+        split: bool = platform.system() == 'Windows',
         token: AbstractToken = DefaultToken(),
     ) -> SubprocessResult:
         """
         About reading from strout and stderr: https://stackoverflow.com/a/28319191/14522393
         """
+        if platform.system() == 'Windows' and not split:
+            raise OSError('Windows arguments should be splitted.')
+
         if timeout is not None and isinstance(token, DefaultToken):
             token = TimeoutToken(timeout)
         elif timeout is not None:
@@ -117,7 +120,6 @@ def split_argument(argument: str) -> List[str]:
         # https://stackoverflow.com/a/35900070/14522393
         if platform.system() == 'Windows':
             return [argument]  # pragma: no cover
-        #return [argument]
         return shlex_split(argument)
 
     def run_killing_thread(self, process: Popen, token: AbstractToken, result: SubprocessResult) -> Thread:  # type: ignore[type-arg]

tests/documentation/test_quick_start.py

@@ -1,10 +1,15 @@
+import os
+import sys
 from io import StringIO
+import platform
 from contextlib import redirect_stdout, redirect_stderr
 
 import suby
+import pytest
 
 
-def test_run_hello_world():
+@pytest.mark.skipif(platform.system() == 'Windows', reason='Windows and not windows have different rules of escaping characters.')
+def test_run_hello_world_not_for_windows():
     stderr_buffer = StringIO()
     stdout_buffer = StringIO()
 
@@ -18,3 +23,21 @@ def test_run_hello_world():
     assert result.stderr == ''
     assert result.returncode == 0
     assert not result.killed_by_token
+
+
+@pytest.mark.skipif(platform.system() != 'Windows', reason='Windows and not windows have different rules of escaping characters.')
+def test_run_hello_world_windows():
+
+    stderr_buffer = StringIO()
+    stdout_buffer = StringIO()
+
+    with redirect_stdout(stdout_buffer), redirect_stderr(stderr_buffer):
+        result = suby('python', '-c', 'print("hello, world!")')
+
+    assert stderr_buffer.getvalue() == ''
+    assert stdout_buffer.getvalue() == 'hello, world!\n'
+
+    assert result.stdout == 'hello, world!\n'
+    assert result.stderr == ''
+    assert result.returncode == 0
+    assert not result.killed_by_token